diff options
| author | Florian Westphal <fw@strlen.de> | 2023-12-08 13:37:27 +0100 |
|---|---|---|
| committer | Florian Westphal <fw@strlen.de> | 2023-12-11 17:12:23 +0100 |
| commit | 21608263cc1ae489326e743957bfe34b05414a44 (patch) | |
| tree | a102d74a080712bc58df2b36ec3b6ab37f5f02dd | |
| parent | 78dffb470fcf7b1c0b1b3d6f43fcc056c337a808 (diff) | |
parser_bison: fix memleak in meta set error handling
We must release the expression here, found via afl++ and
-fsanitize-address build.
Signed-off-by: Florian Westphal <fw@strlen.de>
| -rw-r--r-- | src/parser_bison.y | 1 | ||||
| -rw-r--r-- | tests/shell/testcases/bogons/nft-f/memleak_on_meta_set_errpath | 5 |
2 files changed, 6 insertions, 0 deletions
diff --git a/src/parser_bison.y b/src/parser_bison.y index 64946a43..70acfc57 100644 --- a/src/parser_bison.y +++ b/src/parser_bison.y @@ -5331,6 +5331,7 @@ meta_stmt : META meta_key SET stmt_expr close_scope_meta free_const($2); if (erec != NULL) { erec_queue(erec, state->msgs); + expr_free($4); YYERROR; } diff --git a/tests/shell/testcases/bogons/nft-f/memleak_on_meta_set_errpath b/tests/shell/testcases/bogons/nft-f/memleak_on_meta_set_errpath new file mode 100644 index 00000000..917e8bf8 --- /dev/null +++ b/tests/shell/testcases/bogons/nft-f/memleak_on_meta_set_errpath @@ -0,0 +1,5 @@ +table filter { + chain y { + meta seccark set ct secmark + } +} |