summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2015-06-02 12:53:11 +0200
committerPatrick McHardy <kaber@trash.net>2015-06-02 12:56:53 +0200
commit933fb6b993d9ddd9a96d15edbea393dc56c932e3 (patch)
tree85d8553267e8fae59b5029c343c3d13f91b7ddf3
parent19719a352683fcf32bfb5e3e61a03fc61c1d94cc (diff)
netlink_delinearize: remove obsolete fixme
The FIXME was related to exclusion of string types from cmp length checks. Since with fixed sized helper names the last case where this could happen is gone, remove the FIXME and perform length checks on strings as well. Signed-off-by: Patrick McHardy <kaber@trash.net>
-rw-r--r--src/netlink_delinearize.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c
index ec1a9646..b23d5875 100644
--- a/src/netlink_delinearize.c
+++ b/src/netlink_delinearize.c
@@ -166,9 +166,7 @@ static void netlink_parse_cmp(struct netlink_parse_ctx *ctx,
nld.value = nft_rule_expr_get(nle, NFT_EXPR_CMP_DATA, &nld.len);
right = netlink_alloc_value(loc, &nld);
- // FIXME
- if (left->len && left->dtype && left->dtype->type != TYPE_STRING &&
- left->len != right->len)
+ if (left->len != right->len)
return netlink_error(ctx, loc,
"Relational expression size mismatch");