summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhil Sutter <phil@nwl.cc>2023-01-13 17:09:53 +0100
committerPhil Sutter <phil@nwl.cc>2023-01-13 17:11:18 +0100
commitd4d47e5bdf943be494aeb5d5a29b8f5212acbddf (patch)
treeb80274d7d60010df6b8bba6a9b32d863ad5126a7
parentb83a0416cdc881c6ac35739cd858e4fe5fb2e04f (diff)
optimize: Do not return garbage from stack
If input does not contain a single 'add' command (unusual, but possible), 'ret' value was not initialized by nft_optimize() before returning its value. Fixes: fb298877ece27 ("src: add ruleset optimization infrastructure") Signed-off-by: Phil Sutter <phil@nwl.cc>
-rw-r--r--src/optimize.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/optimize.c b/src/optimize.c
index 12cae00d..289c442d 100644
--- a/src/optimize.c
+++ b/src/optimize.c
@@ -1217,7 +1217,7 @@ static int cmd_optimize(struct nft_ctx *nft, struct cmd *cmd)
int nft_optimize(struct nft_ctx *nft, struct list_head *cmds)
{
struct cmd *cmd;
- int ret;
+ int ret = 0;
list_for_each_entry(cmd, cmds, list) {
switch (cmd->op) {