diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2021-06-17 17:29:11 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2021-06-18 09:40:20 +0200 |
| commit | 7a0e26723496c268ac639012e882b5dc9ba88f9f (patch) | |
| tree | 4e1c32f685bad0dde30c19aa97cf8f956c3c2788 /src | |
| parent | c9ec9cb4af83881712e0f818144673d6f607cd89 (diff) | |
rule: memleak of list of timeout policies
Release list of ct timeout policy when object is freed.
Direct leak of 160 byte(s) in 2 object(s) allocated from:
#0 0x7fc0273ad330 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xe9330)
#1 0x7fc0231377c4 in xmalloc /home/.../devel/nftables/src/utils.c:36
#2 0x7fc023137983 in xzalloc /home/.../devel/nftables/src/utils.c:75
#3 0x7fc0231f64d6 in nft_parse /home/.../devel/nftables/src/parser_bison.y:4448
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/netlink.c | 1 | ||||
| -rw-r--r-- | src/rule.c | 8 |
2 files changed, 9 insertions, 0 deletions
diff --git a/src/netlink.c b/src/netlink.c index f2c1a4a1..c5fd3804 100644 --- a/src/netlink.c +++ b/src/netlink.c @@ -1484,6 +1484,7 @@ struct obj *netlink_delinearize_obj(struct netlink_ctx *ctx, obj->ct_helper.l4proto = nftnl_obj_get_u8(nlo, NFTNL_OBJ_CT_HELPER_L4PROTO); break; case NFT_OBJECT_CT_TIMEOUT: + init_list_head(&obj->ct_timeout.timeout_list); obj->ct_timeout.l3proto = nftnl_obj_get_u16(nlo, NFTNL_OBJ_CT_TIMEOUT_L3PROTO); obj->ct_timeout.l4proto = nftnl_obj_get_u8(nlo, NFTNL_OBJ_CT_TIMEOUT_L4PROTO); memcpy(obj->ct_timeout.timeout, @@ -1709,6 +1709,14 @@ void obj_free(struct obj *obj) return; xfree(obj->comment); handle_free(&obj->handle); + if (obj->type == NFT_OBJECT_CT_TIMEOUT) { + struct timeout_state *ts, *next; + + list_for_each_entry_safe(ts, next, &obj->ct_timeout.timeout_list, head) { + list_del(&ts->head); + xfree(ts); + } + } xfree(obj); } |