diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2017-11-23 15:14:01 +0100 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2017-11-24 15:03:28 +0100 |
| commit | 48661c54357aea271bf87ab2b6ef907eafc97e9a (patch) | |
| tree | 9222b459849f9db7332b71866df33225d9b12920 /tests/py/ip | |
| parent | 932847e0c3df8f6ee3dc4478f1ef0728926d9544 (diff) | |
src: deprecate "flow table" syntax, replace it by "meter"
According to bugzilla 1137: "flow tables" should not be syntactically
unique.
"Flow tables are always named, but they don't conform to the way sets,
maps, and dictionaries work in terms of "add" and "delete" and all that.
They are also "flow tables" instead of one word like "flows" or
"throttle" or something.
It seems weird to just have these break the syntactic expectations."
Personally, I never liked the reference to "table" since we have very
specific semantics in terms of what a "table" is netfilter for long
time.
This patch promotes "meter" as the new keyword. The former syntax is
still accepted for a while, just to reduce chances of breaking things.
At some point the former syntax will just be removed.
Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1137
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Acked-by: Arturo Borrero Gonzalez <arturo@netfilter.org>
Diffstat (limited to 'tests/py/ip')
| -rw-r--r-- | tests/py/ip/flowtable.t | 2 | ||||
| -rw-r--r-- | tests/py/ip/flowtable.t.payload | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/tests/py/ip/flowtable.t b/tests/py/ip/flowtable.t index 41d5d3bb..7eaf5731 100644 --- a/tests/py/ip/flowtable.t +++ b/tests/py/ip/flowtable.t @@ -2,4 +2,4 @@ *ip;test-ip;input -flow table xyz { ip saddr timeout 30s counter};ok +meter name xyz { ip saddr timeout 30s counter};ok diff --git a/tests/py/ip/flowtable.t.payload b/tests/py/ip/flowtable.t.payload index 591abf2b..4dbd03d0 100644 --- a/tests/py/ip/flowtable.t.payload +++ b/tests/py/ip/flowtable.t.payload @@ -1,4 +1,4 @@ -# flow table xyz { ip saddr timeout 30s counter} +# meter name xyz { ip saddr timeout 30s counter} xyz test-ip 31 xyz test-ip 0 ip test-ip input |