diff options
author | Florian Westphal <fw@strlen.de> | 2019-01-04 15:57:00 +0100 |
---|---|---|
committer | Florian Westphal <fw@strlen.de> | 2019-01-04 16:00:31 +0100 |
commit | 4d26b6dd3c4c8354a88c4a1aef8ea33229f0a4cc (patch) | |
tree | 1e82c9b480038033c65cd7d17b08f24e149bcd82 /tests/shell/testcases/chains/0011endless_jump_loop_1 | |
parent | eb49882deb3e9ec5eccd6e6106b454e3a6394408 (diff) |
tests: shell: change all test scripts to return 0
The shell-based tests currently encode a return value in the
file name, i.e. foo_1 expects that the script should return '1'
for the test case to pass.
This is very error prone, and one test case is even broken (i.e.,
it returns 1, but because of a different, earlier error).
do_something || exit 1
or
'set -e'
are both pretty common patterns, in both cases tests should fail.
In those test-cases that deliberately test for an error,
nft something_should_fail || exit 0
nft something_should_fail && exit 1
or a similar constructs should be used.
This initial commit modififies all '_1' scripts to return 0 on
success, usually via 'nft wrong || exit 0'.
All tests pass, except the one broken test case that hasn't worked
before either, but where 'set -e' use made it pass (the failing command
is supposed to work, and the command that is supposed to fail is never
run).
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'tests/shell/testcases/chains/0011endless_jump_loop_1')
-rwxr-xr-x | tests/shell/testcases/chains/0011endless_jump_loop_1 | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tests/shell/testcases/chains/0011endless_jump_loop_1 b/tests/shell/testcases/chains/0011endless_jump_loop_1 index adbff8d4..d75932d7 100755 --- a/tests/shell/testcases/chains/0011endless_jump_loop_1 +++ b/tests/shell/testcases/chains/0011endless_jump_loop_1 @@ -10,5 +10,6 @@ $NFT add element t m {2 : jump c2} $NFT add rule t c1 tcp dport vmap @m # kernel should return ELOOP -$NFT add element t m {1 : jump c1} 2>/dev/null +$NFT add element t m {1 : jump c1} 2>/dev/null || exit 0 echo "E: accepted endless jump loop in a vmap" >&2 +exit 1 |