diff options
| author | Štěpán Němec <snemec@redhat.com> | 2021-11-05 12:39:11 +0100 |
|---|---|---|
| committer | Phil Sutter <phil@nwl.cc> | 2021-11-05 14:21:26 +0100 |
| commit | dad3338f1f76a4a5bd782bae9c6b48941dfb1e31 (patch) | |
| tree | b89486b44d92b999726b7cd7c1aa16dcafd1b603 /tests/shell | |
| parent | f5cf15a680e18d06be711c81f21b98ef247ff398 (diff) | |
tests: shell: $NFT needs to be invoked unquoted
The variable has to undergo word splitting, otherwise the shell tries
to find the variable value as an executable, which breaks in cases that
7c8a44b25c22 ("tests: shell: Allow wrappers to be passed as nft command")
intends to support.
Mention this in the shell tests README.
Fixes: d8ccad2a2b73 ("tests: cover baecd1cf2685 ("segtree: Fix segfault when restoring a huge interval set")")
Signed-off-by: Štěpán Němec <snemec@redhat.com>
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'tests/shell')
| -rw-r--r-- | tests/shell/README | 3 | ||||
| -rwxr-xr-x | tests/shell/testcases/sets/0068interval_stack_overflow_0 | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/tests/shell/README b/tests/shell/README index ea2b0b98..3af17a9e 100644 --- a/tests/shell/README +++ b/tests/shell/README @@ -29,4 +29,7 @@ which contains the nft command being tested. You can pass an arbitrary $NFT value as well: # NFT=/usr/local/sbin/nft ./run-tests.sh +Note that, to support usage such as NFT='valgrind nft', tests must +invoke $NFT unquoted. + By default, the tests are run with the nft binary at '../../src/nft' diff --git a/tests/shell/testcases/sets/0068interval_stack_overflow_0 b/tests/shell/testcases/sets/0068interval_stack_overflow_0 index 134282de..66205724 100755 --- a/tests/shell/testcases/sets/0068interval_stack_overflow_0 +++ b/tests/shell/testcases/sets/0068interval_stack_overflow_0 @@ -26,4 +26,4 @@ table inet test68_table { } EOF -( ulimit -s 128 && "$NFT" -f "$ruleset_file" ) +( ulimit -s 128 && $NFT -f "$ruleset_file" ) |