From 113ed02e1e69b53e145f92db1c8a0a5bf1e742f4 Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Thu, 20 May 2021 15:11:37 +0200 Subject: expr_postprocess: Avoid an unintended fall through Parsing a range expression, the switch case fell through to prefix expression case, thereby recursing once more for expr->left. This seems not to have caused harm, but is certainly not intended. Fixes: ee4391d0ac1e7 ("nat: transform range to prefix expression when possible") Signed-off-by: Phil Sutter --- src/netlink_delinearize.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c index 75869d33..a71d06d7 100644 --- a/src/netlink_delinearize.c +++ b/src/netlink_delinearize.c @@ -2450,6 +2450,7 @@ static void expr_postprocess(struct rule_pp_ctx *ctx, struct expr **exprp) case EXPR_RANGE: expr_postprocess(ctx, &expr->left); expr_postprocess(ctx, &expr->right); + break; case EXPR_PREFIX: expr_postprocess(ctx, &expr->prefix); break; -- cgit v1.2.3