From 1b5fdcbb3564fdb52cc11dedbb446701f3ce53e6 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Tue, 28 Jul 2020 19:39:12 +0200 Subject: evaluate: memleak in invalid default policy definition Release the clone expression from the exit path. Fixes: 5173151863d3 ("evaluate: replace variable expression by the value expression") Signed-off-by: Pablo Neira Ayuso --- src/evaluate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/evaluate.c b/src/evaluate.c index a84e9609..a9822ebc 100644 --- a/src/evaluate.c +++ b/src/evaluate.c @@ -2017,8 +2017,10 @@ static int expr_evaluate_variable(struct eval_ctx *ctx, struct expr **exprp) { struct expr *new = expr_clone((*exprp)->sym->expr); - if (expr_evaluate(ctx, &new) < 0) + if (expr_evaluate(ctx, &new) < 0) { + expr_free(new); return -1; + } expr_free(*exprp); *exprp = new; -- cgit v1.2.3