From 92591aa0da84821238107f2f1515a57cbbd2cf6a Mon Sep 17 00:00:00 2001 From: Eric Garver Date: Wed, 1 May 2019 12:34:45 -0400 Subject: parser_json: fix crash on add rule to bad references Pass the location via the handle so the error leg in rule_translate_index() can reference it. Applies to invalid references to tables, chains, and indexes. Fixes: 586ad210368b ("libnftables: Implement JSON parser") Signed-off-by: Eric Garver Acked-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- src/parser_json.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/parser_json.c b/src/parser_json.c index c57c4b8a..3dc3a5c5 100644 --- a/src/parser_json.c +++ b/src/parser_json.c @@ -2429,7 +2429,11 @@ static struct cmd *json_parse_cmd_add_chain(struct json_ctx *ctx, json_t *root, static struct cmd *json_parse_cmd_add_rule(struct json_ctx *ctx, json_t *root, enum cmd_ops op, enum cmd_obj obj) { - struct handle h = { 0 }; + struct handle h = { + .table.location = *int_loc, + .chain.location = *int_loc, + .index.location = *int_loc, + }; const char *family = "", *comment = NULL; struct rule *rule; size_t index; -- cgit v1.2.3