From 933fb6b993d9ddd9a96d15edbea393dc56c932e3 Mon Sep 17 00:00:00 2001 From: Patrick McHardy Date: Tue, 2 Jun 2015 12:53:11 +0200 Subject: netlink_delinearize: remove obsolete fixme The FIXME was related to exclusion of string types from cmp length checks. Since with fixed sized helper names the last case where this could happen is gone, remove the FIXME and perform length checks on strings as well. Signed-off-by: Patrick McHardy --- src/netlink_delinearize.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c index ec1a9646..b23d5875 100644 --- a/src/netlink_delinearize.c +++ b/src/netlink_delinearize.c @@ -166,9 +166,7 @@ static void netlink_parse_cmp(struct netlink_parse_ctx *ctx, nld.value = nft_rule_expr_get(nle, NFT_EXPR_CMP_DATA, &nld.len); right = netlink_alloc_value(loc, &nld); - // FIXME - if (left->len && left->dtype && left->dtype->type != TYPE_STRING && - left->len != right->len) + if (left->len != right->len) return netlink_error(ctx, loc, "Relational expression size mismatch"); -- cgit v1.2.3