From b342ba4a765340dbc7cfd4d510485f95a6edcbe3 Mon Sep 17 00:00:00 2001 From: Eric Leblond Date: Mon, 18 Nov 2013 00:54:44 +0100 Subject: jump: fix logic in netlink linearize Logic in the test was inverted. The result was the jump string not to be set. Reported-by: Alex Chapman Signed-off-by: Eric Leblond Signed-off-by: Pablo Neira Ayuso --- src/netlink_linearize.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/netlink_linearize.c b/src/netlink_linearize.c index da8be202..e64e92a8 100644 --- a/src/netlink_linearize.c +++ b/src/netlink_linearize.c @@ -440,7 +440,8 @@ static void netlink_gen_immediate(struct netlink_linearize_ctx *ctx, nft_rule_expr_set(nle, NFT_EXPR_IMM_DATA, nld.value, nld.len); break; case EXPR_VERDICT: - if (nft_rule_expr_is_set(nle, NFT_EXPR_IMM_CHAIN)) { + if ((expr->chain != NULL) && + !nft_rule_expr_is_set(nle, NFT_EXPR_IMM_CHAIN)) { nft_rule_expr_set_str(nle, NFT_EXPR_IMM_CHAIN, nld.chain); } -- cgit v1.2.3