From cc0b5ec1661634dc6e2f1d3ab35a6a8650927858 Mon Sep 17 00:00:00 2001 From: Anatole Denis Date: Mon, 2 Jan 2017 16:30:01 +0100 Subject: scanner: fix search_in_include_path test clang emits a warning in this function as we're using a boolean as the third argument to strncmp. Indeed, this function only checks the first byte of the path as is, so files beginning with . will be incorrectly included from the current working directory instead of the include directory. Fixes: f92a1a5c4a87 ("scanner: honor absolute and relative paths via include file") Signed-off-by: Anatole Denis Signed-off-by: Pablo Neira Ayuso --- src/scanner.l | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/scanner.l') diff --git a/src/scanner.l b/src/scanner.l index 69406bd0..6b441b54 100644 --- a/src/scanner.l +++ b/src/scanner.l @@ -635,8 +635,8 @@ err: static bool search_in_include_path(const char *filename) { - return (strncmp(filename, "./", strlen("./") != 0) && - strncmp(filename, "../", strlen("../") != 0) && + return (strncmp(filename, "./", strlen("./")) != 0 && + strncmp(filename, "../", strlen("../")) != 0 && filename[0] != '/'); } -- cgit v1.2.3