From 0155bc4df3e9985e4784baff7752959e1b817900 Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Tue, 15 Aug 2017 01:43:03 +0200 Subject: netlink: Fix segfault when using --echo flag Commit 07b45939972eb ("src: introduce struct nft_cache") added cache pointer to struct netlink_mon_handler and the code assumes it is never NULL. Therefore initialize it in the dummy version of netlink_mon_handler in netlink_echo_callback(). Fixes: b99c4d072d996 ("Implement --echo option") Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- src/netlink.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/netlink.c b/src/netlink.c index 8aef8d9a..f631c26b 100644 --- a/src/netlink.c +++ b/src/netlink.c @@ -3075,12 +3075,14 @@ static int netlink_events_cb(const struct nlmsghdr *nlh, void *data) int netlink_echo_callback(const struct nlmsghdr *nlh, void *data) { + struct netlink_ctx *ctx = data; struct netlink_mon_handler echo_monh = { .format = NFTNL_OUTPUT_DEFAULT, - .ctx = data, + .ctx = ctx, .loc = &netlink_location, .monitor_flags = 0xffffffff, .cache_needed = true, + .cache = ctx->cache, }; if (!echo_monh.ctx->octx->echo) -- cgit v1.2.3