From 39d453a15dd3e1a349edc5618861aad63991419a Mon Sep 17 00:00:00 2001 From: Harsha Sharma Date: Fri, 24 Nov 2017 00:25:14 +0530 Subject: evaluate: print error for null string Print error "Empty string is not allowed", eg. # nft add rule filter input meta iifname '""' add rule filter input meta iifname "" ^^ Error: Empty String is not allowed Signed-off-by: Harsha Sharma Signed-off-by: Pablo Neira Ayuso --- src/evaluate.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/evaluate.c b/src/evaluate.c index b0ce9f63..758e7bbe 100644 --- a/src/evaluate.c +++ b/src/evaluate.c @@ -235,7 +235,10 @@ static int expr_evaluate_string(struct eval_ctx *ctx, struct expr **exprp) memset(data + len, 0, data_len - len); mpz_export_data(data, expr->value, BYTEORDER_HOST_ENDIAN, len); - assert(strlen(data) > 0); + if (strlen(data) == 0) + return expr_error(ctx->msgs, expr, + "Empty string is not allowed"); + datalen = strlen(data) - 1; if (data[datalen] != '*') { /* We need to reallocate the constant expression with the right -- cgit v1.2.3