From 788c986343bc24bd0272e8aa409121ffe51f1ef3 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Mon, 15 Aug 2016 13:14:18 +0200 Subject: src: quote user-defined strings when used from rule selectors The following selectors display strings using quotes: * meta iifname * meta oifname * meta ibriport * meta obriport However, the following do not: * meta oif * meta iif * meta skuid * meta skgid * meta iifgroup * meta oifgroup * meta rtclassid * ct label Given they refer to user-defined values, neither keywords nor internal built-in known values, let's quote the output of this. This patch modifies symbolic_constant_print() so we can signal this to indicate if the string needs to be quoted. Signed-off-by: Pablo Neira Ayuso --- tests/py/inet/udp.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tests/py/inet/udp.t') diff --git a/tests/py/inet/udp.t b/tests/py/inet/udp.t index ea9c87b4..060985c8 100644 --- a/tests/py/inet/udp.t +++ b/tests/py/inet/udp.t @@ -52,5 +52,5 @@ udp checksum { 33-55};ok - udp checksum != { 33-55};ok # limit impact to lo -iif lo udp checksum set 0;ok -iif lo udp dport set 65535;ok +iif "lo" udp checksum set 0;ok +iif "lo" udp dport set 65535;ok -- cgit v1.2.3