From 8bbf030baa8169312e81c5a43a5ee2adfeb925d5 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Tue, 12 Jan 2016 16:38:19 +0100 Subject: tests/py: don't test log statement from protocol match I think this unit tests should be self-contained at some level. The shell/ directory should be used to catch regressions at ruleset level, ie. these kind of combinations. Another motivation is that I want that netdev/ingress gets tested (coming in a follow up patch), and we don't support log there yet, so I would need to skip this test for that case. Signed-off-by: Pablo Neira Ayuso --- tests/py/inet/tcp.t | 1 - tests/py/inet/tcp.t.payload.inet | 9 --------- tests/py/inet/tcp.t.payload.ip | 9 --------- tests/py/inet/tcp.t.payload.ip6 | 9 --------- 4 files changed, 28 deletions(-) (limited to 'tests/py/inet') diff --git a/tests/py/inet/tcp.t b/tests/py/inet/tcp.t index cc19ed4c..4a147bca 100644 --- a/tests/py/inet/tcp.t +++ b/tests/py/inet/tcp.t @@ -83,7 +83,6 @@ tcp window { 33, 55, 67, 88};ok tcp window { 33-55};ok - tcp window != { 33-55};ok -tcp checksum 23456 log drop;ok tcp checksum 22;ok tcp checksum != 233;ok tcp checksum 33-45;ok diff --git a/tests/py/inet/tcp.t.payload.inet b/tests/py/inet/tcp.t.payload.inet index 21b21abc..5d54f876 100644 --- a/tests/py/inet/tcp.t.payload.inet +++ b/tests/py/inet/tcp.t.payload.inet @@ -381,15 +381,6 @@ inet test-inet input [ payload load 2b @ transport header + 14 => reg 1 ] [ lookup reg 1 set set%d ] -# tcp checksum 23456 log drop -inet test-inet input - [ meta load l4proto => reg 1 ] - [ cmp eq reg 1 0x00000006 ] - [ payload load 2b @ transport header + 16 => reg 1 ] - [ cmp eq reg 1 0x0000a05b ] - [ log prefix (null) ] - [ immediate reg 0 drop ] - # tcp checksum 22 inet test-inet input [ meta load l4proto => reg 1 ] diff --git a/tests/py/inet/tcp.t.payload.ip b/tests/py/inet/tcp.t.payload.ip index 34c97143..fb5316fb 100644 --- a/tests/py/inet/tcp.t.payload.ip +++ b/tests/py/inet/tcp.t.payload.ip @@ -381,15 +381,6 @@ ip test-ip4 input [ payload load 2b @ transport header + 14 => reg 1 ] [ lookup reg 1 set set%d ] -# tcp checksum 23456 log drop -ip test-ip4 input - [ payload load 1b @ network header + 9 => reg 1 ] - [ cmp eq reg 1 0x00000006 ] - [ payload load 2b @ transport header + 16 => reg 1 ] - [ cmp eq reg 1 0x0000a05b ] - [ log prefix (null) ] - [ immediate reg 0 drop ] - # tcp checksum 22 ip test-ip4 input [ payload load 1b @ network header + 9 => reg 1 ] diff --git a/tests/py/inet/tcp.t.payload.ip6 b/tests/py/inet/tcp.t.payload.ip6 index 44decab4..1d9dd1f5 100644 --- a/tests/py/inet/tcp.t.payload.ip6 +++ b/tests/py/inet/tcp.t.payload.ip6 @@ -381,15 +381,6 @@ ip6 test-ip6 input [ payload load 2b @ transport header + 14 => reg 1 ] [ lookup reg 1 set set%d ] -# tcp checksum 23456 log drop -ip6 test-ip6 input - [ payload load 1b @ network header + 6 => reg 1 ] - [ cmp eq reg 1 0x00000006 ] - [ payload load 2b @ transport header + 16 => reg 1 ] - [ cmp eq reg 1 0x0000a05b ] - [ log prefix (null) ] - [ immediate reg 0 drop ] - # tcp checksum 22 ip6 test-ip6 input [ payload load 1b @ network header + 6 => reg 1 ] -- cgit v1.2.3