From 8d9e663e64be13edc6192e8b2d756c391709d4ca Mon Sep 17 00:00:00 2001 From: Florian Westphal Date: Wed, 15 Mar 2017 14:21:56 +0100 Subject: tests: add insert-failure test It should not be possible to add a ip6 restricted helper to ip family. Signed-off-by: Florian Westphal Acked-by: Pablo Neira Ayuso --- tests/py/ip/objects.t | 1 + tests/py/nft-test.py | 17 ++++++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-) (limited to 'tests/py') diff --git a/tests/py/ip/objects.t b/tests/py/ip/objects.t index ec8e8fd9..742ec6af 100644 --- a/tests/py/ip/objects.t +++ b/tests/py/ip/objects.t @@ -6,6 +6,7 @@ %cnt2 type counter;ok %qt1 type quota 25 mbytes;ok %qt2 type quota over 1 kbytes;ok +%cthelp2 type ct helper { type \"ftp\" protocol tcp\; l3proto ip6\; };fail ip saddr 192.168.1.3 counter name "cnt2";ok ip saddr 192.168.1.3 counter name "cnt3";fail diff --git a/tests/py/nft-test.py b/tests/py/nft-test.py index b2240407..8d1df3bc 100755 --- a/tests/py/nft-test.py +++ b/tests/py/nft-test.py @@ -517,12 +517,23 @@ def obj_add(o, test_result, filename, lineno): print_error(reason, filename, lineno) return -1 - if not _obj_exist(o, filename, lineno): - reason = "I have just added the " + obj_handle + \ - " to the table " + table.name + " but it does not exist" + exist = _obj_exist(o, filename, lineno) + + if exist: + if test_result == "ok": + return 0 + reason = "I added the " + obj_handle + \ + " to the table " + table.name + " but it should have failed" print_error(reason, filename, lineno) return -1 + if test_result == "fail": + return 0 + + reason = "I have just added the " + obj_handle + \ + " to the table " + table.name + " but it does not exist" + print_error(reason, filename, lineno) + return -1 def obj_delete(table, filename=None, lineno=None): ''' -- cgit v1.2.3