From d55bdfac89610474115fdc976d28d5f23b06c32e Mon Sep 17 00:00:00 2001 From: Eric Jallot Date: Tue, 8 Oct 2019 20:06:32 +0200 Subject: tests: shell: fix failed tests due to missing quotes Add double quotes to protect newlines when using <<< redirection. See also commit b878cb7d83855. Signed-off-by: Eric Jallot Signed-off-by: Phil Sutter --- tests/shell/testcases/flowtable/0001flowtable_0 | 2 +- tests/shell/testcases/listing/0015dynamic_0 | 2 +- tests/shell/testcases/listing/0017objects_0 | 2 +- tests/shell/testcases/listing/0018data_0 | 2 +- tests/shell/testcases/listing/0019set_0 | 2 +- tests/shell/testcases/maps/0007named_ifname_dtype_0 | 3 +-- tests/shell/testcases/nft-f/0002rollback_rule_0 | 4 ++-- tests/shell/testcases/nft-f/0003rollback_jump_0 | 4 ++-- tests/shell/testcases/nft-f/0004rollback_set_0 | 4 ++-- tests/shell/testcases/nft-f/0005rollback_map_0 | 4 ++-- tests/shell/testcases/nft-f/0006action_object_0 | 2 +- tests/shell/testcases/nft-f/0017ct_timeout_obj_0 | 2 +- tests/shell/testcases/nft-f/0018ct_expectation_obj_0 | 2 +- tests/shell/testcases/sets/0029named_ifname_dtype_0 | 2 +- 14 files changed, 18 insertions(+), 19 deletions(-) (limited to 'tests/shell/testcases') diff --git a/tests/shell/testcases/flowtable/0001flowtable_0 b/tests/shell/testcases/flowtable/0001flowtable_0 index 8336ec5a..2e180994 100755 --- a/tests/shell/testcases/flowtable/0001flowtable_0 +++ b/tests/shell/testcases/flowtable/0001flowtable_0 @@ -12,4 +12,4 @@ EXPECTED='table inet t { }' set -e -$NFT -f - <<< $EXPECTED +$NFT -f - <<< "$EXPECTED" diff --git a/tests/shell/testcases/listing/0015dynamic_0 b/tests/shell/testcases/listing/0015dynamic_0 index 5ddc4ad8..4ff74e32 100755 --- a/tests/shell/testcases/listing/0015dynamic_0 +++ b/tests/shell/testcases/listing/0015dynamic_0 @@ -12,7 +12,7 @@ EXPECTED="table ip filter { set -e -$NFT -f - <<< $EXPECTED +$NFT -f - <<< "$EXPECTED" GET="$($NFT list set ip filter test_set)" if [ "$EXPECTED" != "$GET" ] ; then diff --git a/tests/shell/testcases/listing/0017objects_0 b/tests/shell/testcases/listing/0017objects_0 index 14d61438..8a586e80 100755 --- a/tests/shell/testcases/listing/0017objects_0 +++ b/tests/shell/testcases/listing/0017objects_0 @@ -8,7 +8,7 @@ EXPECTED="table inet filter { set -e -$NFT -f - <<< $EXPECTED +$NFT -f - <<< "$EXPECTED" $NFT flush map inet filter countermap GET="$($NFT list map inet filter countermap)" diff --git a/tests/shell/testcases/listing/0018data_0 b/tests/shell/testcases/listing/0018data_0 index 767fe13a..544b6bf5 100755 --- a/tests/shell/testcases/listing/0018data_0 +++ b/tests/shell/testcases/listing/0018data_0 @@ -8,7 +8,7 @@ EXPECTED="table inet filter { set -e -$NFT -f - <<< $EXPECTED +$NFT -f - <<< "$EXPECTED" $NFT flush map inet filter ipmap GET="$($NFT list map inet filter ipmap)" diff --git a/tests/shell/testcases/listing/0019set_0 b/tests/shell/testcases/listing/0019set_0 index 04eb0faf..54a8a064 100755 --- a/tests/shell/testcases/listing/0019set_0 +++ b/tests/shell/testcases/listing/0019set_0 @@ -8,7 +8,7 @@ EXPECTED="table inet filter { set -e -$NFT -f - <<< $EXPECTED +$NFT -f - <<< "$EXPECTED" $NFT flush set inet filter ipset GET="$($NFT list set inet filter ipset)" diff --git a/tests/shell/testcases/maps/0007named_ifname_dtype_0 b/tests/shell/testcases/maps/0007named_ifname_dtype_0 index 4c7e7895..b5c5116b 100755 --- a/tests/shell/testcases/maps/0007named_ifname_dtype_0 +++ b/tests/shell/testcases/maps/0007named_ifname_dtype_0 @@ -15,5 +15,4 @@ EXPECTED="table inet t { }" set -e -$NFT -f - <<< $EXPECTED - +$NFT -f - <<< "$EXPECTED" diff --git a/tests/shell/testcases/nft-f/0002rollback_rule_0 b/tests/shell/testcases/nft-f/0002rollback_rule_0 index 33e1212d..8a9ca84a 100755 --- a/tests/shell/testcases/nft-f/0002rollback_rule_0 +++ b/tests/shell/testcases/nft-f/0002rollback_rule_0 @@ -27,13 +27,13 @@ table ip t2 { } }" -$NFT -f - <<< $GOOD_RULESET +$NFT -f - <<< "$GOOD_RULESET" if [ $? -ne 0 ] ; then echo "E: unable to load good ruleset" >&2 exit 1 fi -$NFT -f - <<< $BAD_RULESET 2>/dev/null +$NFT -f - <<< "$BAD_RULESET" 2>/dev/null if [ $? -eq 0 ] ; then echo "E: bogus ruleset loaded?" >&2 exit 1 diff --git a/tests/shell/testcases/nft-f/0003rollback_jump_0 b/tests/shell/testcases/nft-f/0003rollback_jump_0 index 294a234e..6fb6f4e8 100755 --- a/tests/shell/testcases/nft-f/0003rollback_jump_0 +++ b/tests/shell/testcases/nft-f/0003rollback_jump_0 @@ -27,13 +27,13 @@ table ip t2 { } }" -$NFT -f - <<< $GOOD_RULESET +$NFT -f - <<< "$GOOD_RULESET" if [ $? -ne 0 ] ; then echo "E: unable to load good ruleset" >&2 exit 1 fi -$NFT -f - <<< $BAD_RULESET 2>/dev/null +$NFT -f - <<< "$BAD_RULESET" 2>/dev/null if [ $? -eq 0 ] ; then echo "E: bogus ruleset loaded?" >&2 exit 1 diff --git a/tests/shell/testcases/nft-f/0004rollback_set_0 b/tests/shell/testcases/nft-f/0004rollback_set_0 index 512840ef..bcc55df9 100755 --- a/tests/shell/testcases/nft-f/0004rollback_set_0 +++ b/tests/shell/testcases/nft-f/0004rollback_set_0 @@ -27,13 +27,13 @@ table ip t2 { } }" -$NFT -f - <<< $GOOD_RULESET +$NFT -f - <<< "$GOOD_RULESET" if [ $? -ne 0 ] ; then echo "E: unable to load good ruleset" >&2 exit 1 fi -$NFT -f - <<< $BAD_RULESET 2>/dev/null +$NFT -f - <<< "$BAD_RULESET" 2>/dev/null if [ $? -eq 0 ] ; then echo "E: bogus ruleset loaded?" >&2 exit 1 diff --git a/tests/shell/testcases/nft-f/0005rollback_map_0 b/tests/shell/testcases/nft-f/0005rollback_map_0 index b1eb3dd3..913595d7 100755 --- a/tests/shell/testcases/nft-f/0005rollback_map_0 +++ b/tests/shell/testcases/nft-f/0005rollback_map_0 @@ -30,13 +30,13 @@ table ip t2 { } }" -$NFT -f - <<< $GOOD_RULESET +$NFT -f - <<< "$GOOD_RULESET" if [ $? -ne 0 ] ; then echo "E: unable to load good ruleset" >&2 exit 1 fi -$NFT -f - <<< $BAD_RULESET 2>/dev/null +$NFT -f - <<< "$BAD_RULESET" 2>/dev/null if [ $? -eq 0 ] ; then echo "E: bogus ruleset loaded?" >&2 exit 1 diff --git a/tests/shell/testcases/nft-f/0006action_object_0 b/tests/shell/testcases/nft-f/0006action_object_0 index fab3070f..ddee661d 100755 --- a/tests/shell/testcases/nft-f/0006action_object_0 +++ b/tests/shell/testcases/nft-f/0006action_object_0 @@ -40,7 +40,7 @@ RULESET=$(for family in $FAMILIES ; do generate1 $family done) -$NFT -f - <<< $RULESET +$NFT -f - <<< "$RULESET" if [ $? -ne 0 ] ; then echo "E: unable to load ruleset 1" >&2 exit 1 diff --git a/tests/shell/testcases/nft-f/0017ct_timeout_obj_0 b/tests/shell/testcases/nft-f/0017ct_timeout_obj_0 index 1d6a0f7c..4f407793 100755 --- a/tests/shell/testcases/nft-f/0017ct_timeout_obj_0 +++ b/tests/shell/testcases/nft-f/0017ct_timeout_obj_0 @@ -13,4 +13,4 @@ EXPECTED='table ip filter { }' set -e -$NFT -f - <<< $EXPECTED +$NFT -f - <<< "$EXPECTED" diff --git a/tests/shell/testcases/nft-f/0018ct_expectation_obj_0 b/tests/shell/testcases/nft-f/0018ct_expectation_obj_0 index eb9df3ce..4f9872f6 100755 --- a/tests/shell/testcases/nft-f/0018ct_expectation_obj_0 +++ b/tests/shell/testcases/nft-f/0018ct_expectation_obj_0 @@ -15,4 +15,4 @@ EXPECTED='table ip filter { }' set -e -$NFT -f - <<< $EXPECTED +$NFT -f - <<< "$EXPECTED" diff --git a/tests/shell/testcases/sets/0029named_ifname_dtype_0 b/tests/shell/testcases/sets/0029named_ifname_dtype_0 index 724f1667..39b3c90c 100755 --- a/tests/shell/testcases/sets/0029named_ifname_dtype_0 +++ b/tests/shell/testcases/sets/0029named_ifname_dtype_0 @@ -21,4 +21,4 @@ EXPECTED="table inet t { }" set -e -$NFT -f - <<< $EXPECTED +$NFT -f - <<< "$EXPECTED" -- cgit v1.2.3