diff options
author | Eric Leblond <eric@inl.fr> | 2008-07-31 10:41:57 +0200 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2008-07-31 10:41:57 +0200 |
commit | 14a8a1e7dd1301002c99598a2b067cde3ca19b6e (patch) | |
tree | 3a9036bcafca17c49cc6b91850d759bd5dec1b2e /filter | |
parent | a52690d2dbb0e14d705ba990cda9b7869a747c0b (diff) |
cleanup: fix compilation warning related to signed and unsigned comparisons
This patch fixes the warning related to signed and unsigned comparaison.
Signed-off-by: Eric Leblond <eric@inl.fr>
Diffstat (limited to 'filter')
-rw-r--r-- | filter/raw2packet/ulogd_raw2packet_BASE.c | 2 | ||||
-rw-r--r-- | filter/ulogd_filter_MARK.c | 4 | ||||
-rw-r--r-- | filter/ulogd_filter_PWSNIFF.c | 3 |
3 files changed, 5 insertions, 4 deletions
diff --git a/filter/raw2packet/ulogd_raw2packet_BASE.c b/filter/raw2packet/ulogd_raw2packet_BASE.c index 7c6fd26..e61d904 100644 --- a/filter/raw2packet/ulogd_raw2packet_BASE.c +++ b/filter/raw2packet/ulogd_raw2packet_BASE.c @@ -694,7 +694,7 @@ static int _interp_iphdr(struct ulogd_pluginstance *pi, u_int32_t len) GET_VALUE(pi->input.keys, INKEY_RAW_PCKT).ptr; void *nexthdr = (u_int32_t *)iph + iph->ihl; - if (len < sizeof(struct iphdr) || len <= iph->ihl * 4) + if (len < sizeof(struct iphdr) || len <= (u_int32_t)(iph->ihl * 4)) return ULOGD_IRET_OK; len -= iph->ihl * 4; diff --git a/filter/ulogd_filter_MARK.c b/filter/ulogd_filter_MARK.c index ff31fe5..98f5dae 100644 --- a/filter/ulogd_filter_MARK.c +++ b/filter/ulogd_filter_MARK.c @@ -74,14 +74,14 @@ static int interp_mark(struct ulogd_pluginstance *pi) if (pp_is_valid(inp, KEY_CT_MARK)) { if ((GET_VALUE(inp, KEY_CT_MARK).ui32 & pi->config_kset->ces[MARK_MASK].u.value) != - pi->config_kset->ces[MARK_MARK].u.value + (u_int32_t) pi->config_kset->ces[MARK_MARK].u.value ) { return ULOGD_IRET_STOP; } } else if (pp_is_valid(inp, KEY_OOB_MARK)) { if ((GET_VALUE(inp, KEY_OOB_MARK).ui32 & pi->config_kset->ces[MARK_MASK].u.value) != - pi->config_kset->ces[MARK_MARK].u.value + (u_int32_t) pi->config_kset->ces[MARK_MARK].u.value ) { return ULOGD_IRET_STOP; } diff --git a/filter/ulogd_filter_PWSNIFF.c b/filter/ulogd_filter_PWSNIFF.c index 290e4cb..3cbafb6 100644 --- a/filter/ulogd_filter_PWSNIFF.c +++ b/filter/ulogd_filter_PWSNIFF.c @@ -66,7 +66,8 @@ static int interp_pwsniff(struct ulogd_pluginstance *pi) struct tcphdr *tcph; unsigned int tcplen; unsigned char *ptr, *begp, *pw_begp, *endp, *pw_endp; - int len, pw_len, i, cont = 0; + int len, pw_len, cont = 0; + unsigned int i; if (!IS_VALID(pi->input.keys[0])) return ULOGD_IRET_STOP; |