diff options
| author | Jan Engelhardt <jengelh@inai.de> | 2012-06-05 10:34:56 +0200 |
|---|---|---|
| committer | Jan Engelhardt <jengelh@inai.de> | 2012-06-05 10:36:12 +0200 |
| commit | 357f91980470a192d9a982444718e77660a0c56a (patch) | |
| tree | 07dc2b1be992ee5cfcad2a17e6ed657e2502863e /output | |
| parent | 5dc52c43c4d9e0e8a6813cdcd8e1d12a9f1e3fe8 (diff) | |
sqlite: resolve compiler warnings
In file included from /usr/include/string.h:642:0,
from ulogd_output_SQLITE3.c:34:
In function 'strncat',
inlined from 'db_count_cols' at ulogd_output_SQLITE3.c:306:9,
inlined from 'sqlite3_init_db' at ulogd_output_SQLITE3.c:328:11:
/usr/include/bits/string3.h:152:3: warning: call to __builtin___strncat_chk might overflow destination buffer [enabled by default]
I: Statement might be overflowing a buffer in strncat. Common mistake:
BAD: strncat(buffer,charptr,sizeof(buffer)) is wrong, it takes the left over size as 3rd argument
GOOD: strncat(buffer,charptr,sizeof(buffer)-strlen(buffer)-1)
E: ulogd2 bufferoverflowstrncat ulogd_output_SQLITE3.c:328:11
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Diffstat (limited to 'output')
| -rw-r--r-- | output/sqlite3/ulogd_output_SQLITE3.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/output/sqlite3/ulogd_output_SQLITE3.c b/output/sqlite3/ulogd_output_SQLITE3.c index 3cd2106..dffdda3 100644 --- a/output/sqlite3/ulogd_output_SQLITE3.c +++ b/output/sqlite3/ulogd_output_SQLITE3.c @@ -303,7 +303,7 @@ db_count_cols(struct ulogd_pluginstance *pi, sqlite3_stmt **stmt) struct sqlite3_priv *priv = (void *)pi->private; char query[SELECT_ALL_LEN + CONFIG_VAL_STRING_LEN] = SELECT_ALL_STR; - strncat(query, table_ce(pi), LINE_LEN); + strncat(query, table_ce(pi), sizeof(query) - strlen(query) - 1); if (sqlite3_prepare(priv->dbh, query, -1, stmt, 0) != SQLITE_OK) return -1; |