diff options
author | Jeremy Sowden <jeremy@azazel.net> | 2021-11-30 10:55:54 +0000 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2022-01-03 16:40:50 +0100 |
commit | 5cb343adf5c9afa7c72814b8dfb46dc5bc3820d8 (patch) | |
tree | b67721d1a004301b302b0183bfa28e01a1322961 /util | |
parent | b2008092566ab071b234d8650f9f5397e858dbaf (diff) |
db: simplify initialization of ring-buffer
Currently, `strncpy` is used to copy the SQL statement to the ring
buffer, passing the length of the source string, which leads gcc to
complain:
../../util/db.c:231:25: warning: `strncpy` specified bound depends on the length of the source argument
In fact, the ring buffer is sized to be a multiple of the size of the
SQL buffer, and the SQL is simply copied multiple times at increasing
offsets, so use `strcpy` instead.
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'util')
-rw-r--r-- | util/db.c | 5 |
1 files changed, 2 insertions, 3 deletions
@@ -228,9 +228,8 @@ int ulogd_db_start(struct ulogd_pluginstance *upi) di->ring.size, di->ring.length); /* init start of query for each element */ for(i = 0; i < di->ring.size; i++) { - strncpy(di->ring.ring + di->ring.length * i + 1, - di->stmt, - strlen(di->stmt)); + strcpy(di->ring.ring + di->ring.length * i + 1, + di->stmt); } /* init cond & mutex */ ret = pthread_cond_init(&di->ring.cond, NULL); |