From 5cb343adf5c9afa7c72814b8dfb46dc5bc3820d8 Mon Sep 17 00:00:00 2001 From: Jeremy Sowden Date: Tue, 30 Nov 2021 10:55:54 +0000 Subject: db: simplify initialization of ring-buffer Currently, `strncpy` is used to copy the SQL statement to the ring buffer, passing the length of the source string, which leads gcc to complain: ../../util/db.c:231:25: warning: `strncpy` specified bound depends on the length of the source argument In fact, the ring buffer is sized to be a multiple of the size of the SQL buffer, and the SQL is simply copied multiple times at increasing offsets, so use `strcpy` instead. Signed-off-by: Jeremy Sowden Signed-off-by: Pablo Neira Ayuso --- util/db.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/util/db.c b/util/db.c index 339e39e..c1d2436 100644 --- a/util/db.c +++ b/util/db.c @@ -228,9 +228,8 @@ int ulogd_db_start(struct ulogd_pluginstance *upi) di->ring.size, di->ring.length); /* init start of query for each element */ for(i = 0; i < di->ring.size; i++) { - strncpy(di->ring.ring + di->ring.length * i + 1, - di->stmt, - strlen(di->stmt)); + strcpy(di->ring.ring + di->ring.length * i + 1, + di->stmt); } /* init cond & mutex */ ret = pthread_cond_init(&di->ring.cond, NULL); -- cgit v1.2.3