From 03abc9c6502199aa3e096663276f23d09d24e48d Mon Sep 17 00:00:00 2001 From: Jeremy Sowden Date: Tue, 30 Nov 2021 10:55:47 +0000 Subject: output: SQLITE3: fix memory-leak in error-handling When mapping DB column names to input-keys, if we cannot find a key to match a column, the newly allocated `struct field` is leaked. Free it, and log an error message. Signed-off-by: Jeremy Sowden Signed-off-by: Pablo Neira Ayuso --- output/sqlite3/ulogd_output_SQLITE3.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'output') diff --git a/output/sqlite3/ulogd_output_SQLITE3.c b/output/sqlite3/ulogd_output_SQLITE3.c index 554b1b3..41aeeec 100644 --- a/output/sqlite3/ulogd_output_SQLITE3.c +++ b/output/sqlite3/ulogd_output_SQLITE3.c @@ -342,8 +342,12 @@ sqlite3_init_db(struct ulogd_pluginstance *pi) } strncpy(f->name, buf, ULOGD_MAX_KEYLEN); - if ((f->key = ulogd_find_key(pi, buf)) == NULL) + if ((f->key = ulogd_find_key(pi, buf)) == NULL) { + ulogd_log(ULOGD_ERROR, + "SQLITE3: unknown input key: %s\n", buf); + free(f); return -1; + } TAILQ_INSERT_TAIL(&priv->fields, f, link); } -- cgit v1.2.3