summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhil Sutter <phil@nwl.cc>2024-11-05 22:51:58 +0100
committerPhil Sutter <phil@nwl.cc>2024-11-05 23:53:57 +0100
commit7ab577898f83105e3aa38ac96f3ac70c91ecb2ac (patch)
treea6a5081e084ce06d6cb889b7216056003ac81698
parent4220bd83187b6deac7a93d6775aa5e4423b8e2e5 (diff)
src: Eliminate warnings with -Wcalloc-transposed-args
calloc() expects the number of elements in the first parameter, not the second. Swap them and while at it drop one pointless cast (the function returns a void pointer anyway). Signed-off-by: Phil Sutter <phil@nwl.cc> Acked-by: Florian Westphal <fw@strlen.de>
-rw-r--r--src/channel.c4
-rw-r--r--src/channel_mcast.c2
-rw-r--r--src/channel_tcp.c2
-rw-r--r--src/channel_udp.c2
-rw-r--r--src/fds.c4
-rw-r--r--src/filter.c2
-rw-r--r--src/multichannel.c2
-rw-r--r--src/origin.c2
-rw-r--r--src/process.c2
-rw-r--r--src/queue.c2
-rw-r--r--src/tcp.c4
-rw-r--r--src/udp.c4
-rw-r--r--src/vector.c2
13 files changed, 17 insertions, 17 deletions
diff --git a/src/channel.c b/src/channel.c
index acbfa7d..0b89391 100644
--- a/src/channel.c
+++ b/src/channel.c
@@ -56,7 +56,7 @@ channel_buffer_open(int mtu, int headersiz)
{
struct channel_buffer *b;
- b = calloc(sizeof(struct channel_buffer), 1);
+ b = calloc(1, sizeof(struct channel_buffer));
if (b == NULL)
return NULL;
@@ -94,7 +94,7 @@ channel_open(struct channel_conf *cfg)
if (cfg->channel_flags >= CHANNEL_F_MAX)
return NULL;
- c = calloc(sizeof(struct channel), 1);
+ c = calloc(1, sizeof(struct channel));
if (c == NULL)
return NULL;
diff --git a/src/channel_mcast.c b/src/channel_mcast.c
index 35801d7..9c9dc62 100644
--- a/src/channel_mcast.c
+++ b/src/channel_mcast.c
@@ -19,7 +19,7 @@ static void
struct mcast_channel *m;
struct mcast_conf *c = conf;
- m = calloc(sizeof(struct mcast_channel), 1);
+ m = calloc(1, sizeof(struct mcast_channel));
if (m == NULL)
return NULL;
diff --git a/src/channel_tcp.c b/src/channel_tcp.c
index a84603c..173c47a 100644
--- a/src/channel_tcp.c
+++ b/src/channel_tcp.c
@@ -21,7 +21,7 @@ static void
struct tcp_channel *m;
struct tcp_conf *c = conf;
- m = calloc(sizeof(struct tcp_channel), 1);
+ m = calloc(1, sizeof(struct tcp_channel));
if (m == NULL)
return NULL;
diff --git a/src/channel_udp.c b/src/channel_udp.c
index a46a2b1..3b3d754 100644
--- a/src/channel_udp.c
+++ b/src/channel_udp.c
@@ -19,7 +19,7 @@ static void
struct udp_channel *m;
struct udp_conf *c = conf;
- m = calloc(sizeof(struct udp_channel), 1);
+ m = calloc(1, sizeof(struct udp_channel));
if (m == NULL)
return NULL;
diff --git a/src/fds.c b/src/fds.c
index 0b95437..d2c8b59 100644
--- a/src/fds.c
+++ b/src/fds.c
@@ -30,7 +30,7 @@ struct fds *create_fds(void)
{
struct fds *fds;
- fds = (struct fds *) calloc(sizeof(struct fds), 1);
+ fds = calloc(1, sizeof(struct fds));
if (fds == NULL)
return NULL;
@@ -60,7 +60,7 @@ int register_fd(int fd, void (*cb)(void *data), void *data, struct fds *fds)
if (fd > fds->maxfd)
fds->maxfd = fd;
- item = calloc(sizeof(struct fds_item), 1);
+ item = calloc(1, sizeof(struct fds_item));
if (item == NULL)
return -1;
diff --git a/src/filter.c b/src/filter.c
index ee316e7..e863ea9 100644
--- a/src/filter.c
+++ b/src/filter.c
@@ -77,7 +77,7 @@ struct ct_filter *ct_filter_create(void)
int i;
struct ct_filter *filter;
- filter = calloc(sizeof(struct ct_filter), 1);
+ filter = calloc(1, sizeof(struct ct_filter));
if (!filter)
return NULL;
diff --git a/src/multichannel.c b/src/multichannel.c
index 952b567..25a9908 100644
--- a/src/multichannel.c
+++ b/src/multichannel.c
@@ -21,7 +21,7 @@ multichannel_open(struct channel_conf *conf, int len)
if (len <= 0 || len > MULTICHANNEL_MAX)
return NULL;
- m = calloc(sizeof(struct multichannel), 1);
+ m = calloc(1, sizeof(struct multichannel));
if (m == NULL)
return NULL;
diff --git a/src/origin.c b/src/origin.c
index 3c65f3d..e44ffa0 100644
--- a/src/origin.c
+++ b/src/origin.c
@@ -31,7 +31,7 @@ int origin_register(struct nfct_handle *h, int origin_type)
{
struct origin *nlp;
- nlp = calloc(sizeof(struct origin), 1);
+ nlp = calloc(1, sizeof(struct origin));
if (nlp == NULL)
return -1;
diff --git a/src/process.c b/src/process.c
index 08598ee..47f14da 100644
--- a/src/process.c
+++ b/src/process.c
@@ -37,7 +37,7 @@ int fork_process_new(int type, int flags, void (*cb)(void *data), void *data)
}
}
}
- c = calloc(sizeof(struct child_process), 1);
+ c = calloc(1, sizeof(struct child_process));
if (c == NULL)
return -1;
diff --git a/src/queue.c b/src/queue.c
index e94dc7c..cab754b 100644
--- a/src/queue.c
+++ b/src/queue.c
@@ -33,7 +33,7 @@ queue_create(const char *name, int max_objects, unsigned int flags)
{
struct queue *b;
- b = calloc(sizeof(struct queue), 1);
+ b = calloc(1, sizeof(struct queue));
if (b == NULL)
return NULL;
diff --git a/src/tcp.c b/src/tcp.c
index 91fe524..dca0e09 100644
--- a/src/tcp.c
+++ b/src/tcp.c
@@ -31,7 +31,7 @@ struct tcp_sock *tcp_server_create(struct tcp_conf *c)
struct tcp_sock *m;
socklen_t socklen = sizeof(int);
- m = calloc(sizeof(struct tcp_sock), 1);
+ m = calloc(1, sizeof(struct tcp_sock));
if (m == NULL)
return NULL;
@@ -209,7 +209,7 @@ struct tcp_sock *tcp_client_create(struct tcp_conf *c)
{
struct tcp_sock *m;
- m = calloc(sizeof(struct tcp_sock), 1);
+ m = calloc(1, sizeof(struct tcp_sock));
if (m == NULL)
return NULL;
diff --git a/src/udp.c b/src/udp.c
index d0a7f5b..6102328 100644
--- a/src/udp.c
+++ b/src/udp.c
@@ -25,7 +25,7 @@ struct udp_sock *udp_server_create(struct udp_conf *conf)
struct udp_sock *m;
socklen_t socklen = sizeof(int);
- m = calloc(sizeof(struct udp_sock), 1);
+ m = calloc(1, sizeof(struct udp_sock));
if (m == NULL)
return NULL;
@@ -97,7 +97,7 @@ struct udp_sock *udp_client_create(struct udp_conf *conf)
struct udp_sock *m;
socklen_t socklen = sizeof(int);
- m = calloc(sizeof(struct udp_sock), 1);
+ m = calloc(1, sizeof(struct udp_sock));
if (m == NULL)
return NULL;
diff --git a/src/vector.c b/src/vector.c
index 92a5436..29e8fbe 100644
--- a/src/vector.c
+++ b/src/vector.c
@@ -35,7 +35,7 @@ struct vector *vector_create(size_t size)
{
struct vector *v;
- v = calloc(sizeof(struct vector), 1);
+ v = calloc(1, sizeof(struct vector));
if (v == NULL)
return NULL;