summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFiro Yang <firo.yang@suse.com>2021-04-16 12:11:41 +0800
committerPablo Neira Ayuso <pablo@netfilter.org>2021-04-19 16:36:20 +0200
commit52f88f8c22aae3b33f08865f2de659f8a9c4fa5c (patch)
tree45b2a67a856056e8fefe3cd9ca7ad3ddc3adfc71
parentd696eb94e1ed49b1fce8c2da47aedbe9972cbf86 (diff)
ebtables: Spewing an error if --concurrent isn't first argumentHEADmaster
Our customer reported a following issue: If '--concurrent' was passed to ebtables command behind other arguments, '--concurrent' will not take effect sometimes; for a simple example, ebtables -L --concurrent. This is becuase the handling of '--concurrent' is implemented in a passing-order-dependent way. Fixed this problem as Pablo Neira Ayuso suggested by simply spewing an error like following: ./ebtables-legacy -L --concurrent Please put the --concurrent option first. Signed-off-by: Firo Yang <firo.yang@suse.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
-rw-r--r--ebtables.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/ebtables.c b/ebtables.c
index f7dfccf..c1f5c2b 100644
--- a/ebtables.c
+++ b/ebtables.c
@@ -1041,6 +1041,8 @@ big_iface_length:
strcpy(replace->filename, optarg);
break;
case 13 : /* concurrent */
+ if (OPT_COMMANDS)
+ ebt_print_error2("Please put the --concurrent option first");
use_lockfd = 1;
break;
case 1 :