diff options
author | Jan Engelhardt <jengelh@medozas.de> | 2009-10-24 00:45:33 +0200 |
---|---|---|
committer | Jan Engelhardt <jengelh@medozas.de> | 2009-11-03 21:54:20 +0100 |
commit | bbe83862a5e1baf15f7c923352d4afdf59bc70e2 (patch) | |
tree | 790bfd0d6a47968e6c1ed6b2f681ec5578728463 /extensions/libxt_rateest.c | |
parent | bf97128c7262f17a02fec41cdae75b472ba77f88 (diff) |
iptables/extensions: make bundled options work again
When using a bundled option like "-ptcp", 'argv[optind-1]' would
logically point to "-ptcp", but this is obviously not right.
'optarg' is needed instead, which if properly offset to "tcp".
Not all places change optind-based access to optarg; where
look-ahead is needed, such as for tcp's --tcp-flags option for
example, optind is ok.
References: http://bugzilla.netfilter.org/show_bug.cgi?id=611
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Diffstat (limited to 'extensions/libxt_rateest.c')
-rw-r--r-- | extensions/libxt_rateest.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/extensions/libxt_rateest.c b/extensions/libxt_rateest.c index b105529f..62100f4b 100644 --- a/extensions/libxt_rateest.c +++ b/extensions/libxt_rateest.c @@ -259,7 +259,7 @@ rateest_parse(int c, char **argv, int invert, unsigned int *flags, break; case OPT_RATEEST_EQ: - xtables_check_inverse(argv[optind-1], &invert, &optind, 0, argv); + xtables_check_inverse(optarg, &invert, &optind, 0, argv); if (*flags & (1 << c)) xtables_error(PARAMETER_PROBLEM, @@ -272,7 +272,7 @@ rateest_parse(int c, char **argv, int invert, unsigned int *flags, break; case OPT_RATEEST_LT: - xtables_check_inverse(argv[optind-1], &invert, &optind, 0, argv); + xtables_check_inverse(optarg, &invert, &optind, 0, argv); if (*flags & (1 << c)) xtables_error(PARAMETER_PROBLEM, @@ -285,7 +285,7 @@ rateest_parse(int c, char **argv, int invert, unsigned int *flags, break; case OPT_RATEEST_GT: - xtables_check_inverse(argv[optind-1], &invert, &optind, 0, argv); + xtables_check_inverse(optarg, &invert, &optind, 0, argv); if (*flags & (1 << c)) xtables_error(PARAMETER_PROBLEM, |