diff options
author | Phil Sutter <phil@nwl.cc> | 2020-02-21 14:55:52 +0100 |
---|---|---|
committer | Phil Sutter <phil@nwl.cc> | 2020-02-24 12:04:30 +0100 |
commit | d0446ab11182f6ca2adc486a124895f09a220c6e (patch) | |
tree | 4ef308fcb3c979fb672db1182c39ac838223dae8 /iptables/xtables-arp.c | |
parent | 0f40a8bc49d3f7b815336199931a82f919f37c4e (diff) |
xtables: Review nft_init()
Move common code into nft_init(), such as:
* initial zeroing nft_handle fields
* family ops lookup and assignment to 'ops' field
* setting of 'family' field
This requires minor adjustments in xtables_restore_main() so extra field
initialization doesn't happen before nft_init() call.
As a side-effect, this fixes segfaulting xtables-monitor binary when
printing rules for trace event as in that code-path 'ops' field wasn't
initialized.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'iptables/xtables-arp.c')
-rw-r--r-- | iptables/xtables-arp.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/iptables/xtables-arp.c b/iptables/xtables-arp.c index 9cfad762..c8196f08 100644 --- a/iptables/xtables-arp.c +++ b/iptables/xtables-arp.c @@ -500,17 +500,10 @@ int nft_init_arp(struct nft_handle *h, const char *pname) init_extensionsa(); #endif - memset(h, 0, sizeof(*h)); - h->family = NFPROTO_ARP; - - if (nft_init(h, xtables_arp) < 0) + if (nft_init(h, NFPROTO_ARP, xtables_arp) < 0) xtables_error(OTHER_PROBLEM, "Could not initialize nftables layer."); - h->ops = nft_family_ops_lookup(h->family); - if (h->ops == NULL) - xtables_error(PARAMETER_PROBLEM, "Unknown family"); - return 0; } |