diff options
| author | Jeremy Sowden <jeremy@azazel.net> | 2022-12-23 16:24:41 +0000 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2023-01-02 17:19:02 +0100 |
| commit | 3ee08a91b35f050e4ccbaa3f641cf4e23d1a6d33 (patch) | |
| tree | c19d02e11ff9c2df05c4bf68b5857ca6e064d91d /src/conntrack | |
| parent | 43d7b069f43e047b05f0e0ad5d5528afedc4ac1d (diff) | |
conntrack: simplify calculation of `struct sock_fprog` length
When assigning the length to the `struct sock_fprog` object, we
calculate it by multiplying the number of `struct sock_filter` objects,
`j`, by `sizeof(struct sock_filter)` and then dividing by
`sizeof(bsf[0])`, which, since `bsf[0]` is a `struct sock_filter`, is
equal to `sizeof(struct sock_filter)`.
Remove the `sizeof` expressions and just assign `j`.
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/conntrack')
| -rw-r--r-- | src/conntrack/bsf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/conntrack/bsf.c b/src/conntrack/bsf.c index 589bfd8..35cc8b7 100644 --- a/src/conntrack/bsf.c +++ b/src/conntrack/bsf.c @@ -783,7 +783,7 @@ int __setup_netlink_socket_filter(int fd, struct nfct_filter *f) show_filter(bsf, from, j, "---- final verdict ----"); from = j; - sf.len = (sizeof(struct sock_filter) * j) / sizeof(bsf[0]); + sf.len = j; sf.filter = bsf; return setsockopt(fd, SOL_SOCKET, SO_ATTACH_FILTER, &sf, sizeof(sf)); |