diff options
| author | Kevin Cernekee <cernekee@chromium.org> | 2017-01-04 14:30:26 -0800 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2017-01-16 14:29:47 +0100 |
| commit | f58c5b09fb59baf07c942d373fc4d522b27e73c6 (patch) | |
| tree | 8b605198a6a6b16f39b82f103da8eef42cec5e14 /src/internal.h | |
| parent | 7d55aff4686a5910f84b9045c98d6f01e1daa297 (diff) | |
Use __EXPORTED rather than EXPORT_SYMBOL
clang is sensitive to the ordering of
__attribute__((visibility("default"))) relative to the function
body. gcc is not. So if we try to re-declare an existing function
with default visibility, clang prints a warning and generates
a broken .so file in which nfct_helper_* are not exported to library
callers.
Move the attribute up into the function definition to make clang happy.
Signed-off-by: Kevin Cernekee <cernekee@chromium.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/internal.h')
| -rw-r--r-- | src/internal.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/internal.h b/src/internal.h index 3a88d1a..5d78171 100644 --- a/src/internal.h +++ b/src/internal.h @@ -3,10 +3,9 @@ #include "config.h" #ifdef HAVE_VISIBILITY_HIDDEN -# define __visible __attribute__((visibility("default"))) -# define EXPORT_SYMBOL(x) typeof(x) (x) __visible +# define __EXPORTED __attribute__((visibility("default"))) #else -# define EXPORT_SYMBOL +# define __EXPORTED #endif #endif |