diff options
| author | Phil Sutter <phil@nwl.cc> | 2024-03-07 14:49:08 +0100 |
|---|---|---|
| committer | Phil Sutter <phil@nwl.cc> | 2024-04-11 01:27:07 +0200 |
| commit | be0bae0ad31b0adb506f96de083f52a2bd0d4fbf (patch) | |
| tree | 378a1a3ffc541149493c184f0e3c21dfb675cebf /src/expr/lookup.c | |
| parent | c48ac8cba8716a8bc4ff713ee965eee2643cfc31 (diff) | |
With attr_policy in place, data_len has an upper boundary but it may be
lower than the attribute's storage area in which case memcpy() would
read garbage.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'src/expr/lookup.c')
| -rw-r--r-- | src/expr/lookup.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/expr/lookup.c b/src/expr/lookup.c index be04528..21a7fce 100644 --- a/src/expr/lookup.c +++ b/src/expr/lookup.c @@ -37,10 +37,10 @@ nftnl_expr_lookup_set(struct nftnl_expr *e, uint16_t type, switch(type) { case NFTNL_EXPR_LOOKUP_SREG: - memcpy(&lookup->sreg, data, sizeof(lookup->sreg)); + memcpy(&lookup->sreg, data, data_len); break; case NFTNL_EXPR_LOOKUP_DREG: - memcpy(&lookup->dreg, data, sizeof(lookup->dreg)); + memcpy(&lookup->dreg, data, data_len); break; case NFTNL_EXPR_LOOKUP_SET: lookup->set_name = strdup((const char *)data); @@ -48,10 +48,10 @@ nftnl_expr_lookup_set(struct nftnl_expr *e, uint16_t type, return -1; break; case NFTNL_EXPR_LOOKUP_SET_ID: - memcpy(&lookup->set_id, data, sizeof(lookup->set_id)); + memcpy(&lookup->set_id, data, data_len); break; case NFTNL_EXPR_LOOKUP_FLAGS: - memcpy(&lookup->flags, data, sizeof(lookup->flags)); + memcpy(&lookup->flags, data, data_len); break; } return 0; |