diff options
| author | Phil Sutter <phil@nwl.cc> | 2024-03-07 14:49:08 +0100 |
|---|---|---|
| committer | Phil Sutter <phil@nwl.cc> | 2024-04-11 01:27:07 +0200 |
| commit | be0bae0ad31b0adb506f96de083f52a2bd0d4fbf (patch) | |
| tree | 378a1a3ffc541149493c184f0e3c21dfb675cebf /src/expr/numgen.c | |
| parent | c48ac8cba8716a8bc4ff713ee965eee2643cfc31 (diff) | |
With attr_policy in place, data_len has an upper boundary but it may be
lower than the attribute's storage area in which case memcpy() would
read garbage.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'src/expr/numgen.c')
| -rw-r--r-- | src/expr/numgen.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/expr/numgen.c b/src/expr/numgen.c index c5e8772..c015b88 100644 --- a/src/expr/numgen.c +++ b/src/expr/numgen.c @@ -35,16 +35,16 @@ nftnl_expr_ng_set(struct nftnl_expr *e, uint16_t type, switch (type) { case NFTNL_EXPR_NG_DREG: - memcpy(&ng->dreg, data, sizeof(ng->dreg)); + memcpy(&ng->dreg, data, data_len); break; case NFTNL_EXPR_NG_MODULUS: - memcpy(&ng->modulus, data, sizeof(ng->modulus)); + memcpy(&ng->modulus, data, data_len); break; case NFTNL_EXPR_NG_TYPE: - memcpy(&ng->type, data, sizeof(ng->type)); + memcpy(&ng->type, data, data_len); break; case NFTNL_EXPR_NG_OFFSET: - memcpy(&ng->offset, data, sizeof(ng->offset)); + memcpy(&ng->offset, data, data_len); break; default: return -1; |