diff options
| author | Phil Sutter <phil@nwl.cc> | 2018-04-13 16:52:28 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2018-04-14 13:53:02 +0200 |
| commit | ebc3f6636bd5a3c54350d9ed06c1785cb6cc37be (patch) | |
| tree | 3a1e06a00ee077278f2000f9b62f7e53e86c8520 /src/evaluate.c | |
| parent | 23a6c8ccdd293a2c3448e5e197cd0384bef767cb (diff) | |
Review raw payload allocation points
In parser_bison.y, call payload_init_raw() instead of assigning all
fields manually. Also drop manual initialization of flags field: it is
not touched in allocation path, so no need for that.
In stmt_evaluate_payload(), setting dtype field is redundant since
payload_init_raw() does that already.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/evaluate.c')
| -rw-r--r-- | src/evaluate.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/evaluate.c b/src/evaluate.c index efdbb5e5..db63494c 100644 --- a/src/evaluate.c +++ b/src/evaluate.c @@ -1951,7 +1951,6 @@ static int stmt_evaluate_payload(struct eval_ctx *ctx, struct stmt *stmt) payload_byte_size * BITS_PER_BYTE); payload_bytes->payload.desc = payload->payload.desc; - payload_bytes->dtype = &integer_type; payload_bytes->byteorder = payload->byteorder; payload->len = payload_bytes->len; |