diff options
| author | Harsha Sharma <harshasharmaiitr@gmail.com> | 2017-10-09 00:53:43 +0530 |
|---|---|---|
| committer | Florian Westphal <fw@strlen.de> | 2018-03-03 10:37:31 +0100 |
| commit | f128afe52159b65712d47f17353c5f84ca837cf4 (patch) | |
| tree | 6ddfd0560bc27ab82456be6854a06c2b2efc7789 /src/netlink.c | |
| parent | cc8c5fd02448a415473e1afc3f7155bed3940e0d (diff) | |
src: Use snprintf() over strncpy()
Use snprintf() over strncpy() functions as the buffer is not null
terminated in strncpy().
Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
Diffstat (limited to 'src/netlink.c')
| -rw-r--r-- | src/netlink.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/netlink.c b/src/netlink.c index 2ff3ce5e..403f93ca 100644 --- a/src/netlink.c +++ b/src/netlink.c @@ -388,7 +388,7 @@ static void netlink_gen_verdict(const struct expr *expr, switch (expr->verdict) { case NFT_JUMP: case NFT_GOTO: - strncpy(data->chain, expr->chain, NFT_CHAIN_MAXNAMELEN); + snprintf(data->chain, NFT_CHAIN_MAXNAMELEN, "%s", expr->chain); data->chain[NFT_CHAIN_MAXNAMELEN-1] = '\0'; break; } @@ -2648,7 +2648,7 @@ static int netlink_events_newgen_cb(const struct nlmsghdr *nlh, int type, case NFTA_GEN_PROC_NAME: if (mnl_attr_validate(attr, MNL_TYPE_NUL_STRING) < 0) break; - strncpy(name, mnl_attr_get_str(attr), sizeof(name)); + snprintf(name, sizeof(name), "%s", mnl_attr_get_str(attr)); break; case NFTA_GEN_PROC_PID: if (mnl_attr_validate(attr, MNL_TYPE_U32) < 0) |