summaryrefslogtreecommitdiffstats
path: root/src/rule.c
diff options
context:
space:
mode:
authorPablo Neira Ayuso <pablo@netfilter.org>2016-08-24 16:45:06 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2016-08-25 14:21:56 +0200
commitfd33d964a94063d7af6f1713350df980cf440503 (patch)
tree6421d4b11926d51f0cc91ad26d17f4faabb3f3a1 /src/rule.c
parente0f8c894982a57cb1772640715737c7477e7ef8d (diff)
src: create element command
This patch adds the create command, that send the NLM_F_EXCL flag so nf_tables bails out if the element already exists, eg. # nft add element x y { 1.1.1.1 } # nft create element x y { 1.1.1.1 } <cmdline>:1:1-31: Error: Could not process rule: File exists create element x y { 1.1.1.1 } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This update requires nf_tables kernel patches to honor the NLM_F_EXCL. Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/rule.c')
-rw-r--r--src/rule.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/src/rule.c b/src/rule.c
index 54edd8cb..8c58bfa6 100644
--- a/src/rule.c
+++ b/src/rule.c
@@ -881,20 +881,20 @@ static int do_add_chain(struct netlink_ctx *ctx, const struct handle *h,
}
static int __do_add_setelems(struct netlink_ctx *ctx, const struct handle *h,
- struct set *set, struct expr *expr)
+ struct set *set, struct expr *expr, bool excl)
{
if (set->flags & SET_F_INTERVAL &&
set_to_intervals(ctx->msgs, set, expr, true) < 0)
return -1;
- if (netlink_add_setelems(ctx, h, expr) < 0)
+ if (netlink_add_setelems(ctx, h, expr, excl) < 0)
return -1;
return 0;
}
static int do_add_setelems(struct netlink_ctx *ctx, const struct handle *h,
- struct expr *init)
+ struct expr *init, bool excl)
{
struct table *table;
struct set *set;
@@ -902,7 +902,7 @@ static int do_add_setelems(struct netlink_ctx *ctx, const struct handle *h,
table = table_lookup(h);
set = set_lookup(table, h->set);
- return __do_add_setelems(ctx, h, set, init);
+ return __do_add_setelems(ctx, h, set, init, excl);
}
static int do_add_set(struct netlink_ctx *ctx, const struct handle *h,
@@ -911,7 +911,8 @@ static int do_add_set(struct netlink_ctx *ctx, const struct handle *h,
if (netlink_add_set(ctx, h, set, excl) < 0)
return -1;
if (set->init != NULL)
- return __do_add_setelems(ctx, &set->handle, set, set->init);
+ return __do_add_setelems(ctx, &set->handle, set, set->init,
+ false);
return 0;
}
@@ -960,7 +961,7 @@ static int do_command_add(struct netlink_ctx *ctx, struct cmd *cmd, bool excl)
case CMD_OBJ_SET:
return do_add_set(ctx, &cmd->handle, cmd->set, excl);
case CMD_OBJ_SETELEM:
- return do_add_setelems(ctx, &cmd->handle, cmd->expr);
+ return do_add_setelems(ctx, &cmd->handle, cmd->expr, excl);
default:
BUG("invalid command object type %u\n", cmd->obj);
}