diff options
| author | Florian Westphal <fw@strlen.de> | 2023-10-13 12:37:21 +0200 |
|---|---|---|
| committer | Florian Westphal <fw@strlen.de> | 2023-10-13 13:19:37 +0200 |
| commit | 3035062d4da90de567fad03ea7cd37637c4ba5db (patch) | |
| tree | 5399cb80a65c55bc2388eef857e8ea0d3c92b5f7 /src | |
| parent | 2fbbe6802363e98ca4a8210503f5f986bd66bcb0 (diff) | |
evaluate: suggest != in negation error message
when I run sudo nft insert rule filter FORWARD iifname "ens2f1" ip saddr not @ip_macs counter drop comment \" BLOCK ALL NON REGISTERED IP/MACS \"
I get: Error: negation can only be used with singleton bitmask values
And even I did not spot the problem immediately.
I don't think "not" should have been added, its easily confused with
"not equal"/"neq"/!= and hides that this is allegedly a binop.
At least *mention* that the commandline is asking for a binary
operation here and suggest "!=".
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'src')
| -rw-r--r-- | src/evaluate.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/evaluate.c b/src/evaluate.c index c699a9bc..b7ae9113 100644 --- a/src/evaluate.c +++ b/src/evaluate.c @@ -2480,7 +2480,7 @@ static int expr_evaluate_relational(struct eval_ctx *ctx, struct expr **expr) right->dtype->basetype == NULL || right->dtype->basetype->type != TYPE_BITMASK) return expr_binary_error(ctx->msgs, left, right, - "negation can only be used with singleton bitmask values"); + "negation can only be used with singleton bitmask values. Did you mean \"!=\"?"); } switch (right->etype) { |