diff options
author | Shyam Saini <mayhs11saini@gmail.com> | 2017-06-21 14:17:45 +0530 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2017-06-26 19:23:26 +0200 |
commit | 1325419d43184ffe426878af2a2f050e28702852 (patch) | |
tree | fb43e166e97b092644aa3291d3e613e0e6a52f24 /tests/py/nft-test.py | |
parent | b4953803f26c442cdec4cad78a8261e9b97cd015 (diff) |
tests: py: Fail test forcefully when bug is not fixed
When we have "fail" in the test cases then py test doesn't complain
anything, but the test should complain if the fix is not applied.
Before applying 986dea8a4a9d ("evaluate: avoid reference to multiple src
data in statements which set values"), nft throws following error
message and exits with error code 134.
$ nft add rule x y tcp dport set { 0 , 1 }
BUG: unknown expression type set reference
nft: netlink_linearize.c:696: netlink_gen_expr: Assertion `0' failed.
Aborted
This commit enforces nft-test.py to throw error message when the fix
is not applied.
Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'tests/py/nft-test.py')
-rwxr-xr-x | tests/py/nft-test.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/py/nft-test.py b/tests/py/nft-test.py index c1da71aa..8d099a15 100755 --- a/tests/py/nft-test.py +++ b/tests/py/nft-test.py @@ -702,7 +702,7 @@ def rule_add(rule, filename, lineno, force_all_family_option, filename_path): ret = execute_cmd(cmd, filename, lineno, payload_log) state = rule[1].rstrip() - if (ret == 0 and state == "fail") or (ret != 0 and state == "ok"): + if (ret in [0,134] and state == "fail") or (ret != 0 and state == "ok"): if state == "fail": test_state = "This rule should have failed." else: |