diff options
author | Jan Engelhardt <jengelh@medozas.de> | 2009-10-24 00:45:33 +0200 |
---|---|---|
committer | Jan Engelhardt <jengelh@medozas.de> | 2009-11-03 21:54:20 +0100 |
commit | bbe83862a5e1baf15f7c923352d4afdf59bc70e2 (patch) | |
tree | 790bfd0d6a47968e6c1ed6b2f681ec5578728463 /extensions/libipt_icmp.c | |
parent | bf97128c7262f17a02fec41cdae75b472ba77f88 (diff) |
iptables/extensions: make bundled options work again
When using a bundled option like "-ptcp", 'argv[optind-1]' would
logically point to "-ptcp", but this is obviously not right.
'optarg' is needed instead, which if properly offset to "tcp".
Not all places change optind-based access to optarg; where
look-ahead is needed, such as for tcp's --tcp-flags option for
example, optind is ok.
References: http://bugzilla.netfilter.org/show_bug.cgi?id=611
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Diffstat (limited to 'extensions/libipt_icmp.c')
-rw-r--r-- | extensions/libipt_icmp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/extensions/libipt_icmp.c b/extensions/libipt_icmp.c index b109c8ec..37b2fdcd 100644 --- a/extensions/libipt_icmp.c +++ b/extensions/libipt_icmp.c @@ -184,7 +184,7 @@ static int icmp_parse(int c, char **argv, int invert, unsigned int *flags, xtables_error(PARAMETER_PROBLEM, "icmp match: only use --icmp-type once!"); xtables_check_inverse(optarg, &invert, &optind, 0, argv); - parse_icmp(argv[optind-1], &icmpinfo->type, + parse_icmp(optarg, &icmpinfo->type, icmpinfo->code); if (invert) icmpinfo->invflags |= IPT_ICMP_INV; |