diff options
author | Phil Sutter <phil@nwl.cc> | 2018-08-28 21:44:16 +0200 |
---|---|---|
committer | Florian Westphal <fw@strlen.de> | 2018-08-29 17:29:35 +0200 |
commit | 3bb497c61d743ba811e7f501e54cc5071216e1f5 (patch) | |
tree | 672991d2f7422e57cec3e5ccaa0697bb84320393 /extensions/libxt_CLASSIFY.t | |
parent | 0800d9b46b377bc24f15af2c6ae22550b954b6e2 (diff) |
xtables: Fix for deleting rules with comment
Comment match allocation in command_match() and
nft_rule_to_iptables_command_state() were misaligned in that the latter
set match_size to just what is required instead of what the match needs
at maximum like the further. This led to failure when comparing them
later and therefore a rule with a comment could not be deleted.
For comments of a specific length, the udata buffer is padded by
libnftnl so nftnl_rule_get_data() returns a length value which is larger
than the string (including NULL-byte). The trailing data is supposed to
be ignored, but compare_matches() can't not know about that detail and
therefore returns a false-negative if trailing data contains junk. To
overcome this, use strncpy() when populating match data in
nft_rule_to_iptables_command_state(). While being at it, make sure
comment match allocation in that function is identical to what
command_match() does with regards to data allocation size. Also use
xtables_calloc() which does the required error checking.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'extensions/libxt_CLASSIFY.t')
0 files changed, 0 insertions, 0 deletions