diff options
author | Phil Sutter <phil@nwl.cc> | 2018-09-19 15:17:04 +0200 |
---|---|---|
committer | Florian Westphal <fw@strlen.de> | 2018-09-24 11:49:57 +0200 |
commit | 7e50ebabbf9c3a5eeb9511d9f32c6104b56da5cd (patch) | |
tree | 8096c2c282213fa2bdb6c9da6df58f4fa0e72608 /iptables/iptables-xml.c | |
parent | f40ce2d853591220f16c0851bf8665e6967af1f1 (diff) |
Fix a few cases of pointless assignments
This gets rid of a number of assignments which are either redundant or
not used afterwards.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'iptables/iptables-xml.c')
-rw-r--r-- | iptables/iptables-xml.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/iptables/iptables-xml.c b/iptables/iptables-xml.c index 788a67c6..07300efc 100644 --- a/iptables/iptables-xml.c +++ b/iptables/iptables-xml.c @@ -648,7 +648,6 @@ iptables_xml_main(int argc, char *argv[]) ret = 1; } else if (curTable[0]) { unsigned int a; - char *ptr = buffer; char *pcnt = NULL; char *bcnt = NULL; char *parsestart; @@ -661,7 +660,8 @@ iptables_xml_main(int argc, char *argv[]) if (buffer[0] == '[') { /* we have counters in our input */ - ptr = strchr(buffer, ']'); + char *ptr = strchr(buffer, ']'); + if (!ptr) xtables_error(PARAMETER_PROBLEM, "Bad line %u: need ]\n", |