diff options
author | Jan Engelhardt <jengelh@medozas.de> | 2010-12-18 02:04:59 +0100 |
---|---|---|
committer | Jan Engelhardt <jengelh@medozas.de> | 2011-01-31 03:05:34 +0100 |
commit | 73866357e4a7a0fdc1b293bf8863fee2bd56da9e (patch) | |
tree | 1890725e5f327ba14ccf452ff9e5916954d7908f /xtables.c | |
parent | bb8be30857edd501e701c2f22db6c59bd6839c87 (diff) |
iptables: do not print trailing whitespaces
Due to the use of printf("foobar "), iptables emits spaces at the
end-of-line, which looks odd to some users because it causes the
terminal to wrap even if there is seemingly nothing to print.
It may also have other points of annoyance, such as mailers
interpreting a trailing space as an indicator that the paragraph
continues when format=flowed is also on.
And git highlights trailing spaces in red, so let's avoid :)
Preexisting inconsistencies in outputting spaces in the right
spot are also addressed right away.
References: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=429579
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Diffstat (limited to 'xtables.c')
-rw-r--r-- | xtables.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -1641,14 +1641,14 @@ void xtables_save_string(const char *value) length = strcspn(value, no_quote_chars); if (length > 0 && value[length] == 0) { /* no quoting required */ - fputs(value, stdout); putchar(' '); + fputs(value, stdout); } else { /* there is at least one dangerous character in the value, which we have to quote. Write double quotes around the value and escape special characters with a backslash */ - putchar('"'); + printf(" \""); for (p = strpbrk(value, escape_chars); p != NULL; p = strpbrk(value, escape_chars)) { @@ -1662,7 +1662,7 @@ void xtables_save_string(const char *value) /* print the rest and finish the double quoted string */ fputs(value, stdout); - printf("\" "); + putchar('\"'); } } |