diff options
author | Pablo Neira Ayuso <pablo@netfilter.org> | 2019-09-30 16:25:42 +0200 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2019-09-30 16:26:29 +0200 |
commit | 38a7e5b365edce1fc0a972a05bbda0673ca63cad (patch) | |
tree | bd7568505a14739910dc8c09faaeffde2bac869b /src/extra/udp.c | |
parent | 601abd1c71ccdf90753cf294c120ad43fb25dc54 (diff) |
checksum: Fix UDP checksum calculation
The level 4 protocol is part of the UDP and TCP calculations.
nfq_checksum_tcpudp_ipv4() was using IPPROTO_TCP in this calculation,
which gave the wrong answer for UDP.
Based on patch from Alin Nastac, and patch description from Duncan Roe.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/extra/udp.c')
-rw-r--r-- | src/extra/udp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/extra/udp.c b/src/extra/udp.c index 8c44a66..c48a179 100644 --- a/src/extra/udp.c +++ b/src/extra/udp.c @@ -96,7 +96,7 @@ nfq_udp_compute_checksum_ipv4(struct udphdr *udph, struct iphdr *iph) { /* checksum field in header needs to be zero for calculation. */ udph->check = 0; - udph->check = nfq_checksum_tcpudp_ipv4(iph); + udph->check = nfq_checksum_tcpudp_ipv4(iph, IPPROTO_UDP); } EXPORT_SYMBOL(nfq_udp_compute_checksum_ipv4); @@ -115,7 +115,7 @@ nfq_udp_compute_checksum_ipv6(struct udphdr *udph, struct ip6_hdr *ip6h) { /* checksum field in header needs to be zero for calculation. */ udph->check = 0; - udph->check = nfq_checksum_tcpudp_ipv6(ip6h, udph); + udph->check = nfq_checksum_tcpudp_ipv6(ip6h, udph, IPPROTO_UDP); } EXPORT_SYMBOL(nfq_udp_compute_checksum_ipv6); |