diff options
| author | Phil Sutter <phil@nwl.cc> | 2021-03-09 10:40:16 +0100 |
|---|---|---|
| committer | Phil Sutter <phil@nwl.cc> | 2021-03-15 12:23:11 +0100 |
| commit | f4ad4d3879cead150e86c279ac8e4770e4b167b1 (patch) | |
| tree | eac8c2276ecdcc598fff2707975909d01b56f900 /src/expr/bitwise.c | |
| parent | 636fd0daf4890a785e8b165c5ce2c602e5361fcb (diff) | |
expr: Check output type once and for all
There is but a single supported output type left, so check it in expr.c
and drop all the single option switch statements in individual
expressions.
Since the parameter is now unused (and to ensure code correctness), drop
'type' parameter from struct expr_ops' snprintf callback.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'src/expr/bitwise.c')
| -rw-r--r-- | src/expr/bitwise.c | 18 |
1 files changed, 3 insertions, 15 deletions
diff --git a/src/expr/bitwise.c b/src/expr/bitwise.c index ba379a8..139f25f 100644 --- a/src/expr/bitwise.c +++ b/src/expr/bitwise.c @@ -252,8 +252,9 @@ nftnl_expr_bitwise_snprintf_shift(char *buf, size_t size, const char *op, return offset; } -static int nftnl_expr_bitwise_snprintf_default(char *buf, size_t size, - const struct nftnl_expr *e) +static int +nftnl_expr_bitwise_snprintf(char *buf, size_t size, + uint32_t flags, const struct nftnl_expr *e) { struct nftnl_expr_bitwise *bitwise = nftnl_expr_data(e); int err = -1; @@ -273,19 +274,6 @@ static int nftnl_expr_bitwise_snprintf_default(char *buf, size_t size, return err; } -static int -nftnl_expr_bitwise_snprintf(char *buf, size_t size, uint32_t type, - uint32_t flags, const struct nftnl_expr *e) -{ - switch (type) { - case NFTNL_OUTPUT_DEFAULT: - return nftnl_expr_bitwise_snprintf_default(buf, size, e); - default: - break; - } - return -1; -} - struct expr_ops expr_ops_bitwise = { .name = "bitwise", .alloc_len = sizeof(struct nftnl_expr_bitwise), |