diff options
| author | Phil Sutter <phil@nwl.cc> | 2021-03-09 11:14:29 +0100 |
|---|---|---|
| committer | Phil Sutter <phil@nwl.cc> | 2021-03-15 12:22:56 +0100 |
| commit | 5819e46b47c331be01c2f417085c516f3f0aded3 (patch) | |
| tree | cf01f0d7b493d89a13321d706fa18762a3a49ea3 /src/expr/dup.c | |
| parent | 228e8b1746270ee5c4a41b671a01369c75622587 (diff) | |
expr: Fix snprintf buffer length updates
Subsequent calls to snprintf() sometimes reuse 'len' variable although
they should refer to the updated value in 'remain' instead.
Fixes: 676ea569bbe5a ("src: Change parameters of SNPRINTF_BUFFER_SIZE macro.")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'src/expr/dup.c')
| -rw-r--r-- | src/expr/dup.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/expr/dup.c b/src/expr/dup.c index ac39839..7a3ee96 100644 --- a/src/expr/dup.c +++ b/src/expr/dup.c @@ -119,12 +119,12 @@ static int nftnl_expr_dup_snprintf_default(char *buf, size_t len, struct nftnl_expr_dup *dup = nftnl_expr_data(e); if (e->flags & (1 << NFTNL_EXPR_DUP_SREG_ADDR)) { - ret = snprintf(buf + offset, len, "sreg_addr %u ", dup->sreg_addr); + ret = snprintf(buf + offset, remain, "sreg_addr %u ", dup->sreg_addr); SNPRINTF_BUFFER_SIZE(ret, remain, offset); } if (e->flags & (1 << NFTNL_EXPR_DUP_SREG_DEV)) { - ret = snprintf(buf + offset, len, "sreg_dev %u ", dup->sreg_dev); + ret = snprintf(buf + offset, remain, "sreg_dev %u ", dup->sreg_dev); SNPRINTF_BUFFER_SIZE(ret, remain, offset); } |