summaryrefslogtreecommitdiffstats
path: root/src/expr/flow_offload.c
diff options
context:
space:
mode:
authorPhil Sutter <phil@nwl.cc>2023-12-15 16:30:52 +0100
committerPhil Sutter <phil@nwl.cc>2024-03-06 15:40:37 +0100
commitcdde5a8c5a8734f2d540a0ab52c32d41d4d18127 (patch)
treea1641dedae09aa9b6e069d66b4e3212fe3525972 /src/expr/flow_offload.c
parent9da7658c6e25b02f7eeef936835469f4174cbfec (diff)
expr: Introduce struct expr_ops::attr_policy
Similar to kernel's nla_policy, enable expressions to inform about restrictions on attribute use. This allows the generic expression code to perform sanity checks before dispatching to expression ops. For now, this holds only the maximum data len which may be passed to nftnl_expr_set(). While one may debate whether accepting e.g. uint32_t for sreg/dreg attributes is correct, it is necessary to not break nftables. Note that this introduces artificial restrictions on name lengths which were caught by the kernel (if nftables didn't). Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'src/expr/flow_offload.c')
-rw-r--r--src/expr/flow_offload.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/expr/flow_offload.c b/src/expr/flow_offload.c
index 9ab068d..5f209a6 100644
--- a/src/expr/flow_offload.c
+++ b/src/expr/flow_offload.c
@@ -109,10 +109,15 @@ static void nftnl_expr_flow_free(const struct nftnl_expr *e)
xfree(flow->table_name);
}
+static struct attr_policy flow_offload_attr_policy[__NFTNL_EXPR_FLOW_MAX] = {
+ [NFTNL_EXPR_FLOW_TABLE_NAME] = { .maxlen = NFT_NAME_MAXLEN },
+};
+
struct expr_ops expr_ops_flow = {
.name = "flow_offload",
.alloc_len = sizeof(struct nftnl_expr_flow),
.nftnl_max_attr = __NFTNL_EXPR_FLOW_MAX - 1,
+ .attr_policy = flow_offload_attr_policy,
.free = nftnl_expr_flow_free,
.set = nftnl_expr_flow_set,
.get = nftnl_expr_flow_get,