diff options
| author | Phil Sutter <phil@nwl.cc> | 2023-12-15 16:30:52 +0100 |
|---|---|---|
| committer | Phil Sutter <phil@nwl.cc> | 2024-03-06 15:40:37 +0100 |
| commit | cdde5a8c5a8734f2d540a0ab52c32d41d4d18127 (patch) | |
| tree | a1641dedae09aa9b6e069d66b4e3212fe3525972 /src/expr/last.c | |
| parent | 9da7658c6e25b02f7eeef936835469f4174cbfec (diff) | |
expr: Introduce struct expr_ops::attr_policy
Similar to kernel's nla_policy, enable expressions to inform about
restrictions on attribute use. This allows the generic expression code
to perform sanity checks before dispatching to expression ops.
For now, this holds only the maximum data len which may be passed to
nftnl_expr_set().
While one may debate whether accepting e.g. uint32_t for sreg/dreg
attributes is correct, it is necessary to not break nftables.
Note that this introduces artificial restrictions on name lengths which
were caught by the kernel (if nftables didn't).
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'src/expr/last.c')
| -rw-r--r-- | src/expr/last.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/expr/last.c b/src/expr/last.c index 8aa772c..074f463 100644 --- a/src/expr/last.c +++ b/src/expr/last.c @@ -124,10 +124,16 @@ static int nftnl_expr_last_snprintf(char *buf, size_t len, return snprintf(buf, len, "%"PRIu64" ", last->msecs); } +static struct attr_policy last_attr_policy[__NFTNL_EXPR_LAST_MAX] = { + [NFTNL_EXPR_LAST_MSECS] = { .maxlen = sizeof(uint64_t) }, + [NFTNL_EXPR_LAST_SET] = { .maxlen = sizeof(uint32_t) }, +}; + struct expr_ops expr_ops_last = { .name = "last", .alloc_len = sizeof(struct nftnl_expr_last), .nftnl_max_attr = __NFTNL_EXPR_LAST_MAX - 1, + .attr_policy = last_attr_policy, .set = nftnl_expr_last_set, .get = nftnl_expr_last_get, .parse = nftnl_expr_last_parse, |