diff options
| author | Phil Sutter <phil@nwl.cc> | 2024-03-07 14:49:08 +0100 |
|---|---|---|
| committer | Phil Sutter <phil@nwl.cc> | 2024-04-11 01:27:07 +0200 |
| commit | be0bae0ad31b0adb506f96de083f52a2bd0d4fbf (patch) | |
| tree | 378a1a3ffc541149493c184f0e3c21dfb675cebf /src/expr/xfrm.c | |
| parent | c48ac8cba8716a8bc4ff713ee965eee2643cfc31 (diff) | |
With attr_policy in place, data_len has an upper boundary but it may be
lower than the attribute's storage area in which case memcpy() would
read garbage.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'src/expr/xfrm.c')
| -rw-r--r-- | src/expr/xfrm.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/expr/xfrm.c b/src/expr/xfrm.c index dc867a2..2585579 100644 --- a/src/expr/xfrm.c +++ b/src/expr/xfrm.c @@ -33,16 +33,16 @@ nftnl_expr_xfrm_set(struct nftnl_expr *e, uint16_t type, switch(type) { case NFTNL_EXPR_XFRM_KEY: - memcpy(&x->key, data, sizeof(x->key)); + memcpy(&x->key, data, data_len); break; case NFTNL_EXPR_XFRM_DIR: - memcpy(&x->dir, data, sizeof(x->dir)); + memcpy(&x->dir, data, data_len); break; case NFTNL_EXPR_XFRM_SPNUM: - memcpy(&x->spnum, data, sizeof(x->spnum)); + memcpy(&x->spnum, data, data_len); break; case NFTNL_EXPR_XFRM_DREG: - memcpy(&x->dreg, data, sizeof(x->dreg)); + memcpy(&x->dreg, data, data_len); break; default: return -1; |