path: root/src/table.c
diff options
authorArturo Borrero Gonzalez <>2013-02-13 12:15:13 +0000
committerPablo Neira Ayuso <>2013-02-14 09:33:33 +0100
commitd696047efe8d7356f441a52b43a531e6ca8ad3c7 (patch)
tree51363605ba54b46eb4da54571d2ce24fc08a6b9d /src/table.c
parentc6aeca496fc747066ad09ac76c1fc281a948cd68 (diff)
src: change XML output format to use element instead of attributes
There are some problems in using attributes: * they cannot contain multiple values (child elements can) * they are not easily expandable (for future changes) * they cannot describe structures (child elements can) * they are more difficult to manipulate by program code * attribute values are not easy to test against a DTD Extracted from "XML Elements vs. Attributes" at: For more information. Signed-off-by: Arturo Borrero Gonzalez <> Signed-off-by: Pablo Neira Ayuso <>
Diffstat (limited to 'src/table.c')
1 files changed, 3 insertions, 2 deletions
diff --git a/src/table.c b/src/table.c
index eb485b2..d2e07db 100644
--- a/src/table.c
+++ b/src/table.c
@@ -179,8 +179,9 @@ static int nft_table_snprintf_xml(char *buf, size_t size, struct nft_table *t)
return snprintf(buf, size,
"<table name=\"%s\" >\n"
- "\t\t<family value=\"%u\" />\n"
- "\t\t<flags value=\"%d\" table_flags=\"%d\" />\n"
+ "\t\t<family>%u</family>\n"
+ "\t\t<flags>%d</flags>\n"
+ "\t\t<table_flags>%d</table_flags>\n"
"</table>\n" ,
t->name, t->family, t->flags, t->table_flags);