summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorAna Rey <anarey@gmail.com>2014-05-29 13:26:39 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2014-05-29 14:57:39 +0200
commited9108662cfc31eede854197484e2641b4ab76d2 (patch)
tree8a5725a5e26439d1c2799e00b76cfbdb4735b6bc /src
parent26298a9ffc2e216fb6d349b398bf903dd08a1b08 (diff)
expr: log: Code refactoring in nft_rule_expr_log_snprintf
This process adds three new functions: * nft_rule_expr_log_snprintf_default * nft_rule_expr_log_snprintf_xml * nft_rule_expr_log_snprintf_json Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src')
-rw-r--r--src/expr/log.c58
1 files changed, 40 insertions, 18 deletions
diff --git a/src/expr/log.c b/src/expr/log.c
index 5119c20..a61a8d3 100644
--- a/src/expr/log.c
+++ b/src/expr/log.c
@@ -243,32 +243,54 @@ static int nft_rule_expr_log_xml_parse(struct nft_rule_expr *e,
#endif
}
+static int nft_rule_expr_log_snprintf_default(char *buf, size_t len,
+ struct nft_rule_expr *e)
+{
+ struct nft_expr_log *log = nft_expr_data(e);
+
+ return snprintf(buf, len, "prefix '%s' group %u snaplen %u"
+ "qthreshold %u ",
+ log->prefix, log->group, log->snaplen, log->qthreshold);
+}
+
+static int nft_rule_expr_log_snprintf_xml(char *buf, size_t size,
+ struct nft_rule_expr *e)
+{
+ struct nft_expr_log *log = nft_expr_data(e);
+
+ return snprintf(buf, size, "<prefix>%s</prefix>"
+ "<group>%u</group>"
+ "<snaplen>%u</snaplen>"
+ "<qthreshold>%u</qthreshold>",
+ log->prefix, log->group,
+ log->snaplen, log->qthreshold);
+}
+
+static int nft_rule_expr_log_snprintf_json(char *buf, size_t len,
+ struct nft_rule_expr *e)
+{
+ struct nft_expr_log *log = nft_expr_data(e);
+
+ return snprintf(buf, len, "\"prefix\":\"%s\","
+ "\"group\":%u,"
+ "\"snaplen\":%u,"
+ "\"qthreshold\":%u",
+ log->prefix, log->group,
+ log->snaplen, log->qthreshold);
+}
+
+
static int
nft_rule_expr_log_snprintf(char *buf, size_t len, uint32_t type,
uint32_t flags, struct nft_rule_expr *e)
{
- struct nft_expr_log *log = nft_expr_data(e);
-
switch(type) {
case NFT_OUTPUT_DEFAULT:
- return snprintf(buf, len, "prefix '%s' group %u "
- "snaplen %u qthreshold %u ",
- log->prefix, log->group,
- log->snaplen, log->qthreshold);
+ return nft_rule_expr_log_snprintf_default(buf, len, e);
case NFT_OUTPUT_XML:
- return snprintf(buf, len, "<prefix>%s</prefix>"
- "<group>%u</group>"
- "<snaplen>%u</snaplen>"
- "<qthreshold>%u</qthreshold>",
- log->prefix, log->group,
- log->snaplen, log->qthreshold);
+ return nft_rule_expr_log_snprintf_xml(buf, len, e);
case NFT_OUTPUT_JSON:
- return snprintf(buf, len, "\"prefix\":\"%s\","
- "\"group\":%u,"
- "\"snaplen\":%u,"
- "\"qthreshold\":%u",
- log->prefix, log->group,
- log->snaplen, log->qthreshold);
+ return nft_rule_expr_log_snprintf_json(buf, len, e);
default:
break;
}