summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2023-09-08 00:07:21 +0200
committerFlorian Westphal <fw@strlen.de>2023-09-08 11:50:41 +0200
commitfd21f36e831df6e728853dcdaaed9e10a0ecc47d (patch)
tree958c7ac5afb23ed4bc68e45bbe8c3b42662dd949
parenta529b3dcda72a8b60eb2ccc9143faf284b01e49c (diff)
tests/shell: no longer enable verbose output when selecting a test
Previously, when selecting a test on the command line, it would also enable verbose output (except if the "--" separator was used). This convenience feature seems not great because the output from the test badly clutters the "run-test.sh" output. Now that the test results are all on disk, you can search them after the run with great flexibility (grep). Additionally, in previous versions, command line argument parsing was more restrictive, requiring that "-v" always be placed first. Now, the order does not matter, so it's easy to edit the command prompt and append a "-v", if that is what you want. Or if you really like verbose output, then `export VERBOSE=y`. Signed-off-by: Thomas Haller <thaller@redhat.com> Signed-off-by: Florian Westphal <fw@strlen.de>
-rwxr-xr-xtests/shell/run-tests.sh5
1 files changed, 1 insertions, 4 deletions
diff --git a/tests/shell/run-tests.sh b/tests/shell/run-tests.sh
index 6abb6c0c..bb73a771 100755
--- a/tests/shell/run-tests.sh
+++ b/tests/shell/run-tests.sh
@@ -100,7 +100,7 @@ usage() {
echo "OPTIONS:"
echo " -h|--help : Print usage."
echo " -L|--list-tests : List test names and quit."
- echo " -v : Sets VERBOSE=y. Specifying tests without \"--\" enables verbose mode."
+ echo " -v : Sets VERBOSE=y."
echo " -g : Sets DUMPGEN=y."
echo " -V : Sets VALGRIND=y."
echo " -K : Sets KMEMLEAK=y."
@@ -218,10 +218,7 @@ while [ $# -gt 0 ] ; do
shift $#
;;
*)
- # Any unrecognized option is treated as a test name, and also
- # enable verbose tests.
TESTS+=( "$A" )
- VERBOSE=y
;;
esac
done